Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract the dropdown menu from VRF v2 cost calculator #1424

Closed
wants to merge 2 commits into from

Conversation

simkasss
Copy link
Contributor

Relates issues

relates #1423

Description

The dropdown menu is extracted from the VRF v2 cost calculator in order to make it reusable in other components.

@vercel
Copy link

vercel bot commented Jul 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2023 2:26pm

@simkasss
Copy link
Contributor Author

@dwightjl , to make this component reusable on other pages, we should use the same source of chain data (same JSON files) and the same data types in different pages. I plan to modify the VRF v2 cost calculator to use the same source as data feeds. I will also move this JSON file higher (e.g. to src/features/data) so it can be used in all the features. Let me know if it doesn't make sense to you.

@dwightjl dwightjl added the enhancement Enhance existing content or processes label Aug 3, 2023
@simkasss
Copy link
Contributor Author

simkasss commented Aug 3, 2023

Closed in favor of simkasss#1

@simkasss simkasss closed this Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhance existing content or processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants