Test job creation and replacement #9934
Conversation
|
I see that you haven't updated any README files. Would it make sense to do so? |
|
SonarQube Quality Gate
|
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
…nt_tests # Conflicts: # integration-tests/actions/ocr2_helpers_local.go # integration-tests/actions/ocr_helpers_local.go
| } | ||
| jobs, _, err := node.ReadJobs() | ||
| if err != nil { | ||
| return errors.Wrap(err, "error reading jobs from chainlink node") |
There was a problem hiding this comment.
Let's use std lib errors here:
| return errors.Wrap(err, "error reading jobs from chainlink node") | |
| return fmt.Errorf("error reading jobs from chainlink node: %w", err) |
Trying to move away from pkg/errors since it's not necessary or even maintained any more.
There was a problem hiding this comment.
Oh I though the import was new, but I guess there is precedent here for local style. Either way in that case 🤷
…nt_tests # Conflicts: # integration-tests/actions/ocr_helpers_local.go # integration-tests/client/chainlink.go # integration-tests/smoke/ocr2_test.go
|
SonarQube Quality Gate
|
george-dorin
deleted the
chore/BCF-1650_job_deletion_and_replacement_tests
branch
Test that deleting jobs and replacing jobs is covered and tested