fix: add job link to race test notifications #16018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikburt
force-pushed
the
fix/ci-core-race-test-link
branch
2 times, most recently
from
045392a to
5d3a086
Compare
erikburt
force-pushed
the
fix/ci-core-race-test-link
branch
3 times, most recently
from
781e7d3 to
3b58c7a
Compare
erikburt
force-pushed
the
fix/ci-core-race-test-link
branch
from
3b58c7a to
f72c760
Compare
jmank88
approved these changes
Jan 21, 2025
|
chainchad
approved these changes
Jan 22, 2025
Comment on lines
+293
to
+295
| GH_REPO: ${{ github.repository }} | ||
| GH_RUN_ID: ${{ github.run_id }} | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Not blocking but you get the first two for free [1].
GITHUB_REPOSITORY
GITHUB_RUN_ID
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Include the job link in race test failure notifications
Notes
Github doesn't natively support getting the job id, and it is especially bad within matrix jobs.
This command was adapted from: https://stackoverflow.com/questions/59073850/github-actions-get-url-of-test-build, this works because we know a substring of our race tests job so we can do
select(.name | contains("${{ matrix.type.cmd }}").Testing
Echo'd the run_url here: https://github.com/smartcontractkit/chainlink/actions/runs/12896302500/job/35959051383?pr=16018#step:4:14
RE-3429