-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integrate ctf to spin up inmemory chain #15817
base: yn-solana
Are you sure you want to change the base?
Conversation
Quality Gate passedIssues Measures |
AER Report: CI Coreaer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Flakeguard Root Project / Get Tests To Run , GolangCI Lint (deployment) , Core Tests (go_core_tests) , test-scripts , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , Flakeguard Deployment Project / Get Tests To Run , Flakeguard Deployment Project / Run Tests , Flakeguard Deployment Project / Report , Flakeguard Root Project / Run Tests , Flakeguard Root Project / Report , lint , SonarQube Scan , Flakey Test Detection 1. Not enough arguments in call to deployment.NewEnvironment:[Golang Lint (deployment)]Source of Error:environment/crib/types.go:37:59: not enough arguments in call to deployment.NewEnvironment
have (string, "github.com/smartcontractkit/chainlink-common/pkg/logger".Logger, "github.com/smartcontractkit/chainlink/deployment".AddressBook, map[uint64]"github.com/smartcontractkit/chainlink/deployment".Chain, []string, nil, func() "context".Context, "github.com/smartcontractkit/chainlink/deployment".OCRSecrets)
want (string, "github.com/smartcontractkit/chainlink-common/pkg/logger".Logger, "github.com/smartcontractkit/chainlink/deployment".AddressBook, map[uint64]"github.com/smartcontractkit/chainlink/deployment".Chain, map[uint64]"github.com/smartcontractkit/chainlink/deployment".SolChain, []string, "github.com/smartcontractkit/chainlink/deployment".OffchainClient, func() "context".Context, "github.com/smartcontractkit/chainlink/deployment".OCRSecrets) (typecheck) Suggested fix: Update the call to 2. Invalid memory address or nil pointer dereference:[Core Tests (go_core_ccip_deployment_tests)]Source of Error:panic: runtime error: invalid memory address or nil pointer dereference [recovered]
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x40 pc=0x5e4a50a]
github.com/smartcontractkit/chainlink/deployment/environment/memory.solChain(0xc023929040)
/home/runner/work/chainlink/chainlink/deployment/environment/memory/chain.go:108 +0xea
github.com/smartcontractkit/chainlink/deployment/environment/memory.NewMemoryChainsSol(0xc023929040)
/home/runner/work/chainlink/chainlink/deployment/environment/memory/environment.go:198 +0x71
github.com/smartcontractkit/chainlink/deployment/environment/memory.NewMemoryEnvironment(_, {_, _}, _, {0x2, 0x0, 0x4, 0x1, {0x0, {0x0, ...}, ...}})
/home/runner/work/chainlink/chainlink/deployment/environment/memory/environment.go:169 +0xcc Suggested fix: Ensure that all objects are properly initialized before use. Add checks to verify that pointers are not nil before dereferencing them. 3. Updates to go.mod needed:[Clean Go Tidy & Generate]Source of Error:go: updates to go.mod needed; to update it:
go mod tidy
error: exit status 1 Suggested fix: Run |
"--ledger", t.TempDir(), | ||
bcInput := &blockchain.Input{ | ||
Type: "solana", | ||
Image: "f4hrenh9it/solana", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use the official image: https://hub.docker.com/layers/solanalabs/solana/v1.18.26/images/sha256-098806e64d44bccdbedbf07c2edabd1c850b92c8a4a0f81eba9c789034813db6
It contains solana-test-validator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, looks like we've used this more recently: https://github.com/smartcontractkit/chainlink-solana/blob/61c33fc0ce3034c08c99d438833228052ed83044/scripts/setup-localnet/localnet.sh#L18-L26
Can we also get rid of this leftover: chainlink/deployment/solana_chain.go Lines 99 to 103 in eed7d76
For more examples, the |
Requires
Supports