feat(keystone): support multiple OCR3 contracts #15803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MStreet3
force-pushed
the
cappl-404/ocr3-multiple-contracts
branch
from
aacfe02 to
9682e41
Compare
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
bolekk
reviewed
Dec 23, 2024
MStreet3
force-pushed
the
cappl-404/ocr3-multiple-contracts
branch
from
9682e41 to
0cdba03
Compare
MStreet3
force-pushed
the
cappl-404/ocr3-multiple-contracts
branch
from
9bad051 to
56c1438
Compare
bolekk
previously approved these changes
Dec 23, 2024
MStreet3
force-pushed
the
cappl-404/ocr3-multiple-contracts
branch
from
e4990cd to
4d594bd
Compare
|
agparadiso
approved these changes
Dec 27, 2024
| contract, err := contracts.GetOCR3Contract(nil) | ||
| if err != nil { | ||
| env.Logger.Errorf("failed to get OCR3 contract: %s", err) | ||
| return fmt.Errorf("failed to get OCR3 contract: %w", err) |
There was a problem hiding this comment.
@MStreet3 How come we need to both log + return an error here? Does the returned error not get bubbled up to the user when executing the changeset?
| // contract in the set if there is no address specified. If an address is specified, it returns the | ||
| // contract with that address. If the address is specified but not found in the contract set, it returns | ||
| // an error. | ||
| func getOCR3Contract(contracts map[common.Address]*ocr3_capability.OCR3Capability, addr *common.Address) (*ocr3_capability.OCR3Capability, error) { |
There was a problem hiding this comment.
@MStreet3 Style nit: IMO this feels a bit like premature optimization -- why not just inline this code into the ContractSet GetOCR3Contract method?
cedric-cordenier
approved these changes
Jan 6, 2025
joaoluisam
pushed a commit
that referenced
this pull request
Jan 9, 2025
* feat(keystone): enable multiple OCR contracts per chain * fix(keystone/changeset): use common.Address vs string * chore(keystone/changeset): adds unit test * lint(keystone/changeset): fixes loop var lint * refactor(keystone/changeset): move OCR3 selector func and add logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to deploy multiple OCR contracts per chain for workflow dons. This PR:
Requires
Supports