Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract MultiNode to chainlink-framework #15791

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

DylanTinianov
Copy link
Contributor

@DylanTinianov DylanTinianov commented Dec 20, 2024

Extract MultiNode to chainlink-framework
smartcontract-it.atlassian.net/browse/BCFR-944

@DylanTinianov DylanTinianov self-assigned this Dec 20, 2024
Copy link
Contributor

github-actions bot commented Dec 20, 2024

AER Report: CI Core

aer_workflow , commit , Detect Changes , Scheduled Run Frequency , Clean Go Tidy & Generate , Flakeguard Root Project / Get Tests To Run , Core Tests (go_core_tests) , GolangCI Lint (core/scripts) , Core Tests (go_core_tests_integration) , GolangCI Lint (.) , Core Tests (go_core_ccip_deployment_tests) , GolangCI Lint (integration-tests) , Core Tests (go_core_fuzz) , GolangCI Lint (deployment) , Core Tests (go_core_race_tests) , test-scripts , Flakeguard Deployment Project / Get Tests To Run , Flakeguard Deployment Project / Run Tests , Flakeguard Deployment Project / Report , Flakeguard Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/chains/evm/client, ubuntu-latest) , Flakeguard Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/chains/evm/txmgr, ubuntu-latest) , Flakeguard Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/cmd, ubuntu-latest) , Flakeguard Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/services/chainlink, ubuntu-latest) , lint , SonarQube Scan , Flakey Test Detection , Flakeguard Root Project / Report

1. Undefined: commonmocks.Subscription: [go_core_tests_integration]

Source of Error:
# github.com/smartcontractkit/chainlink/v2/core/internal/cltest [github.com/smartcontractkit/chainlink/v2/core/cmd.test]
##[error]core/internal/cltest/cltest.go:1306:114: undefined: commonmocks.Subscription
**Why**: The error indicates that the `commonmocks.Subscription` type is not defined or imported in the `cltest.go` file. This could be due to a missing import or a typo in the type name.

Suggested fix: Ensure that the commonmocks package is correctly imported and that the Subscription type is defined within it. If the type has been renamed or moved, update the reference accordingly.

2. Undefined: commonmocks.NewSubscription: [go_core_tests]

Source of Error:
# github.com/smartcontractkit/chainlink/v2/core/chains/evm/testutils [github.com/smartcontractkit/chainlink/v2/core/chains/evm/client.test]
##[error]core/chains/evm/testutils/client.go:248:34: undefined: commonmocks.Subscription
##[error]core/chains/evm/testutils/client.go:264:21: undefined: commonmocks.NewSubscription
**Why**: The error indicates that the `commonmocks.NewSubscription` function is not defined or imported in the `client.go` file. This could be due to a missing import or a typo in the function name.

Suggested fix: Ensure that the commonmocks package is correctly imported and that the NewSubscription function is defined within it. If the function has been renamed or moved, update the reference accordingly.

3. Not enough arguments in call to utils.JustError: [Golang Lint (.)]

Source of Error:
##[error]core/cmd/aptos_keys_commands_test.go:67:63: not enough arguments in call to utils.JustError
##[error]core/cmd/aptos_keys_commands_test.go:154:85: not enough arguments in call to utils.JustError
##[error]core/cmd/cosmos_keys_commands_test.go:67:63: not enough arguments in call to utils.JustError
##[error]core/cmd/cosmos_keys_commands_test.go:154:86: not enough arguments in call to utils.JustError
##[error]core/cmd/csa_keys_commands_test.go:128:82: not enough arguments in call to utils.JustError
##[error]core/cmd/solana_keys_commands_test.go:67:63: not enough arguments in call to utils.JustError
**Why**: The error indicates that the `utils.JustError` function is being called with insufficient arguments. This could be due to a change in the function's signature.

Suggested fix: Update the calls to utils.JustError to match the new function signature, ensuring all required arguments are provided.

4. Imported and not used: [go_core_tests]

Source of Error:
##[error]core/cmd/evm_transaction_commands_test.go:18:2: "github.com/smartcontractkit/chainlink/v2/core/cmd" imported and not used
**Why**: The error indicates that the `github.com/smartcontractkit/chainlink/v2/core/cmd` package is imported but not used in the `evm_transaction_commands_test.go` file.

Suggested fix: Remove the unused import statement or use the imported package in the code.

5. Node.Stop undefined: [Golang Lint (.)]

Source of Error:
##[error]core/capabilities/integration_tests/framework/don.go:260:18: node.Stop undefined (type *capabilityNode has no field or method Stop)
**Why**: The error indicates that the `Stop` method is not defined for the `capabilityNode` type. This could be due to a missing method implementation or a typo in the method name.

Suggested fix: Ensure that the Stop method is defined for the capabilityNode type. If the method has been renamed or moved, update the reference accordingly.

6. Node.AddJobV2 undefined: [Golang Lint (.)]

Source of Error:
##[error]core/capabilities/integration_tests/framework/don.go:337:15: node.AddJobV2 undefined (type *capabilityNode has no field or method AddJobV2)
**Why**: The error indicates that the `AddJobV2` method is not defined for the `capabilityNode` type. This could be due to a missing method implementation or a typo in the method name.

Suggested fix: Ensure that the AddJobV2 method is defined for the capabilityNode type. If the method has been renamed or moved, update the reference accordingly.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@DylanTinianov DylanTinianov changed the title Extract MultiNode Extract MultiNode to chainlink-framework Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant