Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restore of config in blue-green mode #15778

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

samsondav
Copy link
Collaborator

The OCR3 database must be scoped to each instance, not to the job,
otherwise we can restore the wrong config on node restart.

Requires

Supports

@samsondav samsondav requested review from a team as code owners December 19, 2024 18:03
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

Copy link
Contributor

github-actions bot commented Dec 19, 2024

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

The OCR3 database must be scoped to each instance, not to the job,
otherwise we can restore the wrong config on node restart.
@samsondav samsondav force-pushed the fix_ocr_config_restore_pc branch from f3a9752 to 5fe0080 Compare December 19, 2024 19:59
@samsondav samsondav enabled auto-merge December 20, 2024 13:29
@samsondav samsondav added this pull request to the merge queue Dec 20, 2024
Merged via the queue into develop with commit 043a5ab Dec 20, 2024
168 of 169 checks passed
@samsondav samsondav deleted the fix_ocr_config_restore_pc branch December 20, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants