Fix test snapshot exclusion #15727
Fix test snapshot exclusion #15727
Conversation
RensR
force-pushed
the
fix-test-naming
branch
from
5794862 to
4c8e162
Compare
AER Report: CI Coreaer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , Flakeguard Root Project / Get Tests To Run , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , GolangCI Lint , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , test-scripts , Flakeguard Deployment Project , Flakeguard Root Project / Run Tests , Flakeguard Root Project / Report , lint , SonarQube Scan , Flakey Test Detection 1. GolangCI Lint typechecking error:[Golang Lint]Source of Error:Suggested fix: Ensure that the 2. Permission denied for golangci-lint report:[Golang Lint]Source of Error:Suggested fix: Ensure that the action has write permissions to the directory where 3. GolangCI Lint exit code 3:[Golang Lint]Source of Error:Suggested fix: Address the typechecking error and permission issues to resolve this exit code. 4. No such file or directory for golangci-lint report:[Golang Lint]Source of Error:Suggested fix: Fix the permission issue to ensure the file is created successfully. 5. No files found for upload:[Golang Lint]Source of Error:Suggested fix: Ensure the AER Report: Operator UI CI ran successfully ✅ |
RensR
force-pushed
the
fix-test-naming
branch
from
d671897 to
a305379
Compare
| sourceChainSelector: uint64(_randomNum()), | ||
| onRampAddress: abi.encode(_randomAddress()), | ||
| sourceChainSelector: uint64(vm.randomUint()), | ||
| onRampAddress: abi.encode(vm.randomAddress()), |
# Conflicts: # contracts/gas-snapshots/ccip.gas-snapshot # contracts/src/v0.8/ccip/test/rmn/RMNRemote/RMNRemote.globalCurses.t.sol # core/gethwrappers/ccip/generated/rmn_remote/rmn_remote.go # core/gethwrappers/ccip/generation/generated-wrapper-dependency-versions-do-not-edit.txt
|
This PR cleans up the base contracts for all tests, removing the MockRMN in favor of RMNRemote and moving logic further up the inheritance chain. This should result in (minor) compilation gains. This PR also renames the
revertstests to_RevertWhen_tests so the snapshot excludes them. This was done using regex so not all names are perfect. The ongoing initiative of fixing all test names in any file you touch should continue, but at least we've addresses the snapshot part of it.It appears to be ~1% faster while improving our test suite.