Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delve support #15713

Merged
merged 3 commits into from
Dec 18, 2024
Merged

delve support #15713

merged 3 commits into from
Dec 18, 2024

Conversation

skudasov
Copy link
Collaborator

@skudasov skudasov commented Dec 16, 2024

Add delve support for plugins image

@skudasov skudasov requested review from a team as code owners December 16, 2024 19:07
@skudasov skudasov requested a review from Atrax1 December 16, 2024 19:07
jmank88
jmank88 previously approved these changes Dec 16, 2024
@cedric-cordenier
Copy link
Contributor

cedric-cordenier commented Dec 17, 2024

Is this a potential security risk? 🤔 exposing a debugger port by default seems like it could be unsafe. Afaik we do ship this image to NOPs
.

Atrax1
Atrax1 previously approved these changes Dec 17, 2024
@skudasov skudasov dismissed stale reviews from Atrax1 and jmank88 via c3b542b December 17, 2024 11:39
@skudasov skudasov requested review from jmank88 and Atrax1 December 17, 2024 11:39
Copy link
Contributor

github-actions bot commented Dec 17, 2024

AER Report: CI Core ran successfully ✅

aer_workflow , commit

@skudasov skudasov added this pull request to the merge queue Dec 18, 2024
Merged via the queue into develop with commit 7bcc81e Dec 18, 2024
170 checks passed
@skudasov skudasov deleted the dlv-support branch December 18, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants