Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send ccip exec report info to chain writer. #15708

Closed
wants to merge 5 commits into from

Conversation

winder
Copy link
Contributor

@winder winder commented Dec 16, 2024

Decode execute report info from ReportWithInfo and pass to chain writer. This info includes commit report data (merkle roots) for the messages executed by the report.

@winder winder requested review from a team as code owners December 16, 2024 16:30
@winder winder marked this pull request as draft December 16, 2024 16:30
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

Copy link
Contributor

github-actions bot commented Dec 16, 2024

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Flakeguard Root Project / Get Tests To Run , lint , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Flakeguard Deployment Project / Get Tests To Run , Flakeguard Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/ocrimpls, ubuntu-latest) , Flakeguard Deployment Project / Run Tests , Flakeguard Deployment Project / Report , Flakey Test Detection , SonarQube Scan , Flakeguard Root Project / Report

1. Comment formatting issue: [Golang Lint]

Source of Error:
Golang Lint	2024-12-17T19:05:57.8769771Z ##[error]core/capabilities/ccip/ocrimpls/contract_transmitter.go:67:3: commentFormatting: put a space between `//` and comment text (gocritic)
Golang Lint	2024-12-17T19:05:57.8771760Z 		//Info ccipocr3.ExecuteReportInfo
Golang Lint	2024-12-17T19:05:57.8772801Z 		^

Why: The error is caused by a comment in the code that does not have a space between the // and the comment text. This violates the gocritic linter rule for comment formatting.

Suggested fix: Add a space between // and the comment text. Change //Info ccipocr3.ExecuteReportInfo to // Info ccipocr3.ExecuteReportInfo.

2. Issues found: [Golang Lint]

Source of Error:
Golang Lint	2024-12-17T19:05:57.8788308Z ##[error]issues found
Golang Lint	2024-12-17T19:05:57.8788780Z Ran golangci-lint in 140059ms

Why: This error indicates that the golangci-lint tool found issues in the codebase that need to be addressed.

Suggested fix: Review the detailed linter output and fix the reported issues. In this case, the specific issue is related to comment formatting, as mentioned above.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@winder winder force-pushed the will/ccip-exec-report-info branch from d672c7d to 6728772 Compare December 17, 2024 18:47
@winder winder closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant