Improvements #15695
Closed
Improvements #15695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to
|
| - ChainType: invalid value (Foo): must not be set with this chain id | ||
| - Nodes: missing: must have at least one node | ||
| - ChainType: invalid value (Foo): must be one of arbitrum, astar, celo, gnosis, hedera, kroma, mantle, metis, optimismBedrock, scroll, wemix, xlayer, zkevm, zksync, zircuit, dualBroadcast or omitted | ||
| - HeadTracker.HistoryDepth: invalid value (30): must be greater than or equal to FinalizedBlockOffset | ||
| - GasEstimator.BumpThreshold: invalid value (0): cannot be 0 if auto-purge feature is enabled for Foo | ||
| - Transactions.AutoPurge.Threshold: missing: needs to be set if auto-purge feature is enabled for Foo | ||
| - Transactions.AutoPurge.MinAttempts: missing: needs to be set if auto-purge feature is enabled for Foo | ||
| - TxmV2.TxmV2.BlockTime: missing: must be set if txmv2 feature is enabled |
pavel-raykov
requested changes
Dec 15, 2024
| - 5.Transactions.AutoPurge.DetectionApiUrl: invalid value (): must be set for scroll | ||
| - 5: 2 errors: | ||
| - Transactions.AutoPurge.DetectionApiUrl: invalid value (): must be set for scroll | ||
| - TxmV2.TxmV2.BlockTime: missing: must be set if txmv2 feature is enabled |
| if time.Since(tx.LastBroadcastAt) > threshold && !tx.LastBroadcastAt.IsZero() { | ||
| s.lggr.Debugf("TxID: %v last broadcast was: %v which is more than the max configured duration: %v. Transaction is now considered stuck and will be purged.", | ||
| tx.ID, tx.LastBroadcastAt, threshold) | ||
| if tx.LastBroadcastAt != nil && min(time.Since(*tx.LastBroadcastAt), time.Since(s.lastPurgeMap[tx.FromAddress])) > threshold { |
There was a problem hiding this comment.
Can s.lastPurgeMap[tx.FromAddress] also be nil?
| for _, address := range addresses { | ||
| if _, exists := m.InMemoryStoreMap[address]; exists { | ||
| return fmt.Errorf("address %v already exists in store manager", address) |
There was a problem hiding this comment.
why is it fine to continue updating m.InMemoryStoreMap[address] in case exists is true? (Before this PR, we would have returned)
| @@ -451,6 +452,20 @@ func (c *Chain) ValidateConfig() (err error) { | |||
| err = multierr.Append(err, commonconfig.ErrInvalid{Name: "GasEstimator.BumpThreshold", Value: 0, Msg: fmt.Sprintf("cannot be 0 if Transactions.AutoPurge.MinAttempts is set for %s", chainType)}) | |||
| } | |||
| } | |||
| case chaintype.ChainDualBroadcast: | |||
There was a problem hiding this comment.
Could you please update the PR description? Right now it just says "improvements", whereas, at least it takes care of the ChainDualBroadcast chain type.
Please, also specify what is the old vs new behavior after this PR is merged.
george-dorin
approved these changes
Dec 16, 2024
pavel-raykov
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.