Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump chainlink-data-streams #15673

Closed
wants to merge 1 commit into from
Closed

Bump chainlink-data-streams #15673

wants to merge 1 commit into from

Conversation

pkcll
Copy link
Contributor

@pkcll pkcll commented Dec 12, 2024 •
edited
Loading

Bump chainlink-data-streams to pull/92
master

@pkcll pkcll requested review from a team as code owners December 12, 2024 23:02
@pkcll pkcll requested a review from patrickhuie19 December 12, 2024 23:02
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024 •
edited
Loading

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Flakeguard Root Project / Get Tests To Run , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , GolangCI Lint (core/scripts) , Core Tests (go_core_fuzz) , GolangCI Lint (.) , GolangCI Lint (integration-tests) , Core Tests (go_core_race_tests) , GolangCI Lint (deployment) , test-scripts , Flakeguard Deployment Project / Get Tests To Run , Flakeguard Root Project / Run Tests , Flakeguard Root Project / Report , Flakeguard Deployment Project / Run Tests , Flakeguard Deployment Project / Report , Flakey Test Detection , SonarQube Scan , lint

1. Undefined: ccipocr3.ExecuteReportInfo

[A 1 <= 10 words sentence that describes the error]:[job id where the error happened]

Run Tests	2024-12-20T15:42:02.9474365Z ##[error]../capabilities/ccip/ocrimpls/contract_transmitter.go:73:20: undefined: ccipocr3.ExecuteReportInfo
Run Tests	2024-12-20T15:42:02.9485730Z ##[error]../capabilities/ccip/ocrimpls/contract_transmitter.go:76:24: undefined: ccipocr3.DecodeExecuteReportInfo
Run Tests	2024-12-20T15:42:02.9488178Z ##[error]../capabilities/ccip/ocrimpls/contract_transmitter.go:85:26: undefined: ccipocr3.ExecuteReportInfo
Build binary	2024-12-20T15:43:00.9488040Z ##[error]core/capabilities/ccip/ocrimpls/contract_transmitter.go:73:20: undefined: ccipocr3.ExecuteReportInfo
Build binary	2024-12-20T15:43:00.9499648Z ##[error]core/capabilities/ccip/ocrimpls/contract_transmitter.go:76:24: undefined: ccipocr3.DecodeExecuteReportInfo
Build binary	2024-12-20T15:43:00.9503026Z ##[error]core/capabilities/ccip/ocrimpls/contract_transmitter.go:85:26: undefined: ccipocr3.ExecuteReportInfo
Build binary	2024-12-20T15:42:45.6709639Z ##[error]core/capabilities/ccip/ocrimpls/contract_transmitter.go:73:20: undefined: ccipocr3.ExecuteReportInfo
Build binary	2024-12-20T15:42:45.6720667Z ##[error]core/capabilities/ccip/ocrimpls/contract_transmitter.go:76:24: undefined: ccipocr3.DecodeExecuteReportInfo
Build binary	2024-12-20T15:42:45.6723557Z ##[error]core/capabilities/ccip/ocrimpls/contract_transmitter.go:85:26: undefined: ccipocr3.ExecuteReportInfo
Build binary	2024-12-20T15:42:46.0763626Z ##[error]core/capabilities/ccip/ocrimpls/contract_transmitter.go:73:20: undefined: ccipocr3.ExecuteReportInfo
Build binary	2024-12-20T15:42:46.0775422Z ##[error]core/capabilities/ccip/ocrimpls/contract_transmitter.go:76:24: undefined: ccipocr3.DecodeExecuteReportInfo
Build binary	2024-12-20T15:42:46.0778639Z ##[error]core/capabilities/ccip/ocrimpls/contract_transmitter.go:85:26: undefined: ccipocr3.ExecuteReportInfo
Build binary	2024-12-20T15:42:40.5337484Z ##[error]core/capabilities/ccip/ocrimpls/contract_transmitter.go:73:20: undefined: ccipocr3.ExecuteReportInfo
Build binary	2024-12-20T15:42:40.5551724Z ##[error]core/capabilities/ccip/ocrimpls/contract_transmitter.go:76:24: undefined: ccipocr3.DecodeExecuteReportInfo
Build binary	2024-12-20T15:42:40.5555215Z ##[error]core/capabilities/ccip/ocrimpls/contract_transmitter.go:85:26: undefined: ccipocr3.ExecuteReportInfo
Build binary	2024-12-20T15:42:18.4047528Z ##[error]core/capabilities/ccip/ocrimpls/contract_transmitter.go:73:20: undefined: ccipocr3.ExecuteReportInfo
Build binary	2024-12-20T15:42:18.4059833Z ##[error]core/capabilities/ccip/ocrimpls/contract_transmitter.go:76:24: undefined: ccipocr3.DecodeExecuteReportInfo
Build binary	2024-12-20T15:42:18.4063260Z ##[error]core/capabilities/ccip/ocrimpls/contract_transmitter.go:85:26: undefined: ccipocr3.ExecuteReportInfo
Golang Lint (.)	2024-12-20T15:46:17.1521393Z ##[error]core/capabilities/ccip/ocrimpls/contract_transmitter.go:73:20: undefined: ccipocr3.ExecuteReportInfo
Golang Lint (.)	2024-12-20T15:46:17.1523765Z ##[error]core/capabilities/ccip/ocrimpls/contract_transmitter.go:76:24: undefined: ccipocr3.DecodeExecuteReportInfo
Golang Lint (.)	2024-12-20T15:46:17.1525599Z ##[error]core/capabilities/ccip/ocrimpls/contract_transmitter.go:85:26: undefined: ccipocr3.ExecuteReportInfo

Why: The error occurs because the ccipocr3 package does not contain the ExecuteReportInfo and DecodeExecuteReportInfo definitions, which are being referenced in contract_transmitter.go.

Suggested fix: Ensure that the ccipocr3 package is correctly imported and contains the definitions for ExecuteReportInfo and DecodeExecuteReportInfo. If these functions are missing, they need to be implemented or the references should be removed or replaced with the correct functions.

2. Declared and not used: config

Golang Lint (deployment)	2024-12-20T15:45:07.2240127Z ##[error]deployment/common/changeset/set_config_mcms_test.go:36:2: declared and not used: config (typecheck)
Golang Lint (deployment)	2024-12-20T15:45:07.2242051Z 	config := proposalutils.SingleGroupTimelockConfig(t)
Golang Lint (deployment)	2024-12-20T15:45:07.2242536Z 	^
Golang Lint (deployment)	2024-12-20T15:45:07.2244142Z ##[error]deployment/common/changeset/example/link_transfer_test.go:36:2: declared and not used: config (typecheck)
Golang Lint (deployment)	2024-12-20T15:45:07.2245289Z 	config := proposalutils.SingleGroupMCMS(t)
Golang Lint (deployment)	2024-12-20T15:45:07.2245858Z 	^

Why: The variable config is declared but not used in the test files, which causes the linter to throw an error.

Suggested fix: Remove the unused config variable or use it appropriately within the test functions.

3. Declared and not used: timelock

Golang Lint (deployment)	2024-12-20T15:45:07.2247084Z ##[error]deployment/keystone/changeset/accept_ownership_test.go:54:2: declared and not used: timelock (typecheck)
Golang Lint (deployment)	2024-12-20T15:45:07.2248223Z 	timelock, err := commonchangeset.MaybeLoadMCMSWithTimelockChainState(env.Chains[registrySel], addrs)
Golang Lint (deployment)	2024-12-20T15:45:07.2248905Z 	^

Why: The variable timelock is declared but not used in the test file, which causes the linter to throw an error.

Suggested fix: Remove the unused timelock variable or use it appropriately within the test function.

4. Declared and not used: contracts

Golang Lint (deployment)	2024-12-20T15:45:07.2250061Z ##[error]deployment/keystone/changeset/append_node_capabilities_test.go:91:3: declared and not used: contracts (typecheck)
Golang Lint (deployment)	2024-12-20T15:45:07.2251073Z 		contracts := te.ContractSets()[te.RegistrySelector]
Golang Lint (deployment)	2024-12-20T15:45:07.2251481Z 		^
Golang Lint (deployment)	2024-12-20T15:45:07.2252399Z ##[error]deployment/keystone/changeset/deploy_ocr3_test.go:121:3: declared and not used: contracts (typecheck)
Golang Lint (deployment)	2024-12-20T15:45:07.2253236Z 		contracts := te.ContractSets()[te.RegistrySelector]
Golang Lint (deployment)	2024-12-20T15:45:07.2253645Z 		^
Golang Lint (deployment)	2024-12-20T15:45:07.2254623Z ##[error]deployment/keystone/changeset/update_don_test.go:114:3: declared and not used: contracts (typecheck)
Golang Lint (deployment)	2024-12-20T15:45:07.2255440Z 		contracts := te.ContractSets()[te.RegistrySelector]
Golang Lint (deployment)	2024-12-20T15:45:07.2256023Z 		^

Why: The variable contracts is declared but not used in the test files, which causes the linter to throw an error.

Suggested fix: Remove the unused contracts variable or use it appropriately within the test functions.

5. Declared and not used: ownerChainB

Golang Lint (integration-tests)	2024-12-20T15:45:33.7674951Z ##[error]integration-tests/smoke/ccip/ccip_usdc_test.go:52:2: declared and not used: ownerChainB (typecheck)
Golang Lint (integration-tests)	2024-12-20T15:45:33.7675927Z 	ownerChainB := e.Chains[chainB].DeployerKey
Golang Lint (integration-tests)	2024-12-20T15:45:33.7676353Z 	^

Why: The variable ownerChainB is declared but not used in the test file, which causes the linter to throw an error.

Suggested fix: Remove the unused ownerChainB variable or use it appropriately within the test function.

6. GolangCI Lint exit with code 3

Golang Lint (core/scripts)	2024-12-20T15:44:05.1842766Z level=warning msg="[runner] Can't run linter goanalysis_metalinter: inspect: failed to load package cmd: could not load export data: no export data for \"github.com/smartcontractkit/chainlink/v2/core/cmd\""
Golang Lint (core/scripts)	2024-12-20T15:44:05.1844713Z level=error msg="Running error: can't run linter goanalysis_metalinter\ninspect: failed to load package cmd: could not load export data: no export data for \"github.com/smartcontractkit/chainlink/v2/core/cmd\""
Golang Lint (core/scripts)	2024-12-20T15:44:05.1884851Z ##[error]golangci-lint exit with code 3

Why: The linter failed to load the package cmd because it could not find the export data for github.com/smartcontractkit/chainlink/v2/core/cmd.

Suggested fix: Ensure that the package github.com/smartcontractkit/chainlink/v2/core/cmd is correctly built and the export data is available. This might involve checking the build process or dependencies for the package.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@pkcll pkcll added release-preview build-test-image Will build the e2e test image in integration-tests workflow for PRs build-publish Build and Publish image to SDLC and removed release-preview build-test-image Will build the e2e test image in integration-tests workflow for PRs labels Dec 12, 2024
@pkcll
Copy link
Contributor Author

pkcll commented Dec 13, 2024

@krebernisak @bolekk @patrickhuie19 The CPU issue could effect any LOOPP, it needs to be fixed across the board.

samsondav
samsondav previously approved these changes Dec 13, 2024
View reviewed changes
@pkcll pkcll force-pushed the bump-chainlink-data-streams branch from bee16f9 to d41842f Compare December 20, 2024 15:39
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@pkcll
Copy link
Contributor Author

pkcll commented Dec 20, 2024

Already done as part of #15712

@pkcll pkcll closed this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsondav samsondav samsondav left review comments

@patrickhuie19 patrickhuie19 Awaiting requested review from patrickhuie19 patrickhuie19 is a code owner automatically assigned from smartcontractkit/foundations

Assignees
No one assigned
Labels
build-publish Build and Publish image to SDLC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pkcll @samsondav