Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deployment readme links #15667

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Fix deployment readme links #15667

merged 1 commit into from
Dec 16, 2024

Conversation

connorwstein
Copy link
Contributor

No description provided.

@connorwstein connorwstein requested review from a team as code owners December 12, 2024 17:29
@@ -100,14 +100,14 @@ TODO: Add various examples in deployment/example.
contracts (like MCMS, LinkToken etc) which can be shared
by products.

/deployment/<product>/internal
/deployment/product/internal
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the <product> is good indication to users that it is a placeholder?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue is it renders like /deployment//internal

@connorwstein connorwstein added this pull request to the merge queue Dec 16, 2024
Merged via the queue into develop with commit a6b3b0b Dec 16, 2024
104 of 105 checks passed
@connorwstein connorwstein deleted the readme-fix branch December 16, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants