Update abandon tx functionality to drop related attempts #15616
Merged
+65
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BCFR-1078
Context
The abandon transaction functionality marks
unstarted
,in_progress
, andunconfirmed
transactions asfatal_error
and clears out any assigned nonces. However, attempts forin_progress
orunconfirmed
transactions remained in the db even though these attempts aren't needed for any other TXM process. This was causing a conflict with purged transactions that are marked as fatal with attempts that still need to be bumped and confirmed. The only difference is that purge transactions maintain their noncesChanges