Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/services/ocr2/plugins/ccip: fix racey TestIntegration_CCIP #15572

Merged
merged 1 commit into from
Dec 9, 2024
Merged

core/services/ocr2/plugins/ccip: fix racey TestIntegration_CCIP #15572

merged 1 commit into from
Dec 9, 2024

Conversation

makramkd
Copy link
Contributor

@makramkd makramkd commented Dec 9, 2024 •
edited
Loading

Wrap simulated backend with an object that synchronizes Commit() calls.

Also, remove testhelpers_1_4_0

Requires

Supports

@makramkd
core/services/ocr2/plugins/ccip: fix racey TestIntegration_CCIP
88899f3 
Wrap simulated backend with an object that synchronizes Commit() calls
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@makramkd makramkd marked this pull request as ready for review December 9, 2024 16:55
@makramkd makramkd requested review from a team as code owners December 9, 2024 16:55
jmank88
jmank88 approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@jmank88 jmank88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but maybe consider naming it something like SyncBackend?

@makramkd makramkd added this pull request to the merge queue Dec 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 9, 2024
@makramkd makramkd added this pull request to the merge queue Dec 9, 2024
Merged via the queue into develop with commit a707433 Dec 9, 2024
181 of 182 checks passed
@makramkd makramkd deleted the mk/ccip-4522 branch December 9, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnieeG AnieeG AnieeG approved these changes

@jmank88 jmank88 jmank88 approved these changes

@winder winder Awaiting requested review from winder winder is a code owner automatically assigned from smartcontractkit/ccip-offchain

@rstout rstout Awaiting requested review from rstout rstout is a code owner automatically assigned from smartcontractkit/ccip-offchain

@asoliman92 asoliman92 Awaiting requested review from asoliman92 asoliman92 is a code owner automatically assigned from smartcontractkit/ccip-offchain

@dimkouv dimkouv Awaiting requested review from dimkouv dimkouv is a code owner automatically assigned from smartcontractkit/ccip-offchain

@mateusz-sekara mateusz-sekara Awaiting requested review from mateusz-sekara mateusz-sekara is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xAustinWang 0xAustinWang Awaiting requested review from 0xAustinWang 0xAustinWang is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xnogo 0xnogo Awaiting requested review from 0xnogo 0xnogo is a code owner automatically assigned from smartcontractkit/ccip-offchain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@makramkd @jmank88 @AnieeG