Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAPPL] Fixes to registry syncer #15567

Merged
merged 5 commits into from
Dec 10, 2024
Merged

Conversation

cedric-cordenier
Copy link
Contributor

Requires

Supports

Copy link
Contributor

github-actions bot commented Dec 9, 2024

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Flakeguard Summary

Setting Value
Project github.com/smartcontractkit/chainlink/v2
Max Pass Ratio 100.00%
Test Run Count 3
Race Detection false
Excluded Tests TestChainComponents

Found Flaky Tests ❌

Category Total
Tests 3
Panicked Tests 0
Raced Tests 0
Flaky Tests 1
Flaky Test Ratio 33.33%
Runs 9
Passes 6
Failures 3
Skips 0
Pass Ratio 66.66%
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
Test_RegistrySyncer_EventHandling 0.00% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/relay/evm/capabilities/workflows/syncer false 15.16s Unknown

Copy link
Contributor

github-actions bot commented Dec 9, 2024

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@cedric-cordenier cedric-cordenier force-pushed the fix-start-chain-reader branch 2 times, most recently from 685988f to ade1eb4 Compare December 9, 2024 14:26
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Flakeguard Summary

Setting Value
Project github.com/smartcontractkit/chainlink/v2
Max Pass Ratio 100.00%
Test Run Count 3
Race Detection false
Excluded Tests TestChainComponents

Found Flaky Tests ❌

Category Total
Tests 4
Panicked Tests 0
Raced Tests 0
Flaky Tests 1
Flaky Test Ratio 25.00%
Runs 12
Passes 9
Failures 3
Skips 0
Pass Ratio 75.00%
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
Test_RegistrySyncer_WorkflowRegistered_InitiallyPaused 0.00% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/relay/evm/capabilities/workflows/syncer false 15.163333333s Unknown

@cedric-cordenier cedric-cordenier marked this pull request as ready for review December 10, 2024 08:50
@cedric-cordenier cedric-cordenier requested review from a team as code owners December 10, 2024 08:50
agparadiso
agparadiso previously approved these changes Dec 10, 2024
ettec
ettec previously approved these changes Dec 10, 2024
george-dorin
george-dorin previously approved these changes Dec 10, 2024
Copy link
Contributor

Flakeguard Summary

Setting Value
Project github.com/smartcontractkit/chainlink/v2
Max Pass Ratio 100.00%
Test Run Count 6
Race Detection false
Excluded Tests TestChainComponents

Found Flaky Tests ❌

Category Total
Tests 36
Panicked Tests 0
Raced Tests 1
Flaky Tests 10
Flaky Test Ratio 27.77%
Runs 108
Passes 78
Failures 30
Skips 0
Pass Ratio 72.22%
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
Test_Workflow_Registry_Syncer 0.00% false false true 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/workflows/syncer false 0s @smartcontractkit/keystone
Test_workflowDeletedHandler 0.00% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/workflows/syncer false 23.706666666s @smartcontractkit/keystone
Test_workflowDeletedHandler/success_deleting_existing_engine_and_spec 0.00% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/workflows/syncer false 23.706666666s @smartcontractkit/keystone
Test_workflowPausedActivatedUpdatedHandler 0.00% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/workflows/syncer false 23.326666666s @smartcontractkit/keystone
Test_workflowPausedActivatedUpdatedHandler/success_pausing_activating_and_updating_existing_engine_and_spec 0.00% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/workflows/syncer false 23.326666666s @smartcontractkit/keystone
Test_workflowRegisteredHandler 0.00% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/workflows/syncer false 29.196666666s @smartcontractkit/keystone
Test_workflowRegisteredHandler/skips_fetch_if_config_url_is_missing 0.00% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/workflows/syncer false 16.666666ms @smartcontractkit/keystone
Test_workflowRegisteredHandler/skips_fetch_if_secrets_url_is_missing 0.00% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/workflows/syncer false 10ms @smartcontractkit/keystone
Test_workflowRegisteredHandler/success_with_active_workflow_registered 0.00% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/workflows/syncer false 10ms @smartcontractkit/keystone
Test_workflowRegisteredHandler/success_with_paused_workflow_registered 0.00% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/workflows/syncer false 10ms @smartcontractkit/keystone

@cedric-cordenier cedric-cordenier added this pull request to the merge queue Dec 10, 2024
Merged via the queue into develop with commit 13b3cee Dec 10, 2024
170 of 171 checks passed
@cedric-cordenier cedric-cordenier deleted the fix-start-chain-reader branch December 10, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants