refactor update & append capabilities #15563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
| require.NoError(t, err) | ||
| require.Len(t, csOut.Proposals, 1) | ||
| require.Len(t, csOut.Proposals[0].Transactions, 1) | ||
| require.Len(t, csOut.Proposals[0].Transactions[0].Batch, 2) // add capabilities, update nodes |
| @@ -425,30 +425,19 @@ type RegisteredCapability struct { | |||
| ID [32]byte | |||
| } | |||
|
|
|||
| func FromCapabilitiesRegistryCapability(cap *kcr.CapabilitiesRegistryCapability, e deployment.Environment, registryChainSelector uint64) (*RegisteredCapability, error) { | |||
There was a problem hiding this comment.
thanks. yes there are. i didn't mean to delete this
krehermann
force-pushed
the
ks/cap-cs-refactor
branch
from
02aba69 to
dbedc94
Compare
krehermann
requested review from
patrickhuie19,
bolekk,
akhilchainani,
graham-chainlink and
ecPablo
| proposerMCMSes, | ||
| []timelock.BatchChainOperation{*r.Ops}, | ||
| "proposal to set update node capabilities", | ||
| 0, |
There was a problem hiding this comment.
probably worth parameterizing this just in case you want to add timelock delay in the future. @carte7000 had a good idea here https://github.com/smartcontractkit/chainlink/pull/15525/files#diff-f6eeb14804b5d16769abc3f48ad18187965263d5e5d29345e4079e85199de731R38 to use an MCMS struct being nil/not-nil as a way to signal that but also keep the door open for any other MCMS specific params
There was a problem hiding this comment.
ack, will address in followup; have one more in the stack to merge
bolekk
previously approved these changes
Dec 10, 2024
| @@ -0,0 +1,129 @@ | |||
| package changeset_test | |||
patrickhuie19
previously approved these changes
Dec 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
krehermann
force-pushed
the
ks/cap-cs-refactor
branch
from
f975632 to
4e368e6
Compare
patrickhuie19
approved these changes
Dec 10, 2024
connorwstein
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KS-610
mcms refactoring for update and append capabilities to nodes. these changeset are compound - they write new capabilities and set the nodes. this requires some new layering to support MCMS
Requires
Supports