Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy call proxy instead of using deployer executor keys #15559

Merged
merged 17 commits into from
Dec 10, 2024

Conversation

akhilchainani
Copy link
Contributor

Requires

Supports

Copy link
Contributor

github-actions bot commented Dec 7, 2024

Flakeguard Summary

Setting Value
Project github.com/smartcontractkit/chainlink/deployment/deployment
Max Pass Ratio 100.00%
Test Run Count 12
Race Detection false
Excluded Tests TestAddLane

Found Flaky Tests ❌

Category Total
Tests 37
Panicked Tests 0
Raced Tests 0
Flaky Tests 7
Flaky Test Ratio 18.91%
Runs 108
Passes 87
Failures 21
Skips 3
Pass Ratio 80.55%
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestAddChainInbound 0.00% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset false 35.26s Unknown
TestDeployCCIPContracts 0.00% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset false 2.813333333s Unknown
TestDeployChainContractsChangeset 0.00% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset false 2.07s Unknown
TestInitialDeploy 0.00% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset false 3.816666666s Unknown
TestSmokeState 0.00% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset false 3.763333333s Unknown
TestSmokeView 0.00% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset false 3.733333333s Unknown
Test_NewAcceptOwnershipChangeset 0.00% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset false 3.263333333s Unknown

Copy link
Contributor

github-actions bot commented Dec 7, 2024

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@akhilchainani akhilchainani marked this pull request as ready for review December 8, 2024 19:23
@akhilchainani akhilchainani requested review from a team as code owners December 8, 2024 19:23
Copy link
Collaborator

@graham-chainlink graham-chainlink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@krehermann krehermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small usability & doc changes please

deployment/common/changeset/test_helpers.go Outdated Show resolved Hide resolved
deployment/common/changeset/internal/mcms.go Outdated Show resolved Hide resolved
@graham-chainlink graham-chainlink added this pull request to the merge queue Dec 10, 2024
Merged via the queue into develop with commit 88a0338 Dec 10, 2024
192 of 193 checks passed
@graham-chainlink graham-chainlink deleted the fix/deployment-call-proxy branch December 10, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants