WIP

[cedric-cordenier]

Requires

Supports

[github-actions]

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

• #added For any new functionality added.
• #breaking_change For any functionality that requires manual action for the node to boot.
• #bugfix For bug fixes.
• #changed For any change to the existing functionality.
• #db_update For any feature that introduces updates to database schema.
• #deprecation_notice For any upcoming deprecation functionality.
• #internal For changesets that need to be excluded from the final changelog.
• #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
• #removed For any functionality/config that is removed.
• #updated For any functionality that is updated.
• #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

[github-actions]

Flakeguard Summary

Setting	Value
Project	github.com/smartcontractkit/chainlink/v2
Max Pass Ratio	100.00%
Test Run Count	3
Race Detection	false
Excluded Tests	TestChainComponents

Found Flaky Tests ❌

Category	Total
Tests	3
Panicked Tests	0
Raced Tests	0
Flaky Tests	1
Flaky Test Ratio	33.33%
Runs	9
Passes	6
Failures	3
Skips	0
Pass Ratio	66.66%

Name	Pass Ratio	Panicked?	Timed Out?	Race?	Runs	Successes	Failures	Skips	Package	Package Panicked?	Avg Duration	Code Owners
Test_RegistrySyncer_EventHandling	0.00%	false	false	false	3	0	3	0	github.com/smartcontractkit/chainlink/v2/core/services/relay/evm/capabilities/workflows/syncer	false	15.166666666s	Unknown

[github-actions]

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Flakeguard Root Project / Get Tests To Run , lint , Core Tests (go_core_tests) , Flakeguard Deployment Project , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Flakeguard Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/services/relay/evm/capabilities/workflow... , Flakeguard Root Project / Report , Flakey Test Detection , SonarQube Scan

1. MockContractReader missing method Close:[Golang Lint]

Source of Error:

core/services/workflows/syncer/workflow_registry_test.go:76:11: cannot use reader (variable of type *MockContractReader) as ContractReader value in return statement: *MockContractReader does not implement ContractReader (missing method Close)
core/services/workflows/syncer/workflow_registry_test.go:80:11: cannot use reader (variable of type *MockContractReader) as ContractReader value in return statement: *MockContractReader does not implement ContractReader (missing method Close) (typecheck)

**Why**: The `MockContractReader` struct is missing the `Close` method, which is required to implement the `ContractReader` interface.

Suggested fix: Implement the Close method for the MockContractReader struct to satisfy the ContractReader interface.

2. Flaky tests detected:[Run tests with flakeguard]

Source of Error:

| Test_RegistrySyncer_EventHandling | 0.00% | false | false | false | 3 | 0 | 3 | 0 | github.com/smartcontractkit/chainlink/v2/core/services/relay/evm/capabilities/workflows/syncer | false | 15.17s |
| Test_SecretsWorker | 0.00% | false | false | false | 3 | 0 | 3 | 0 | github.com/smartcontractkit/chainlink/v2/core/services/relay/evm/capabilities/workflows/syncer | false | 15.193333333s |

**Why**: The tests `Test_RegistrySyncer_EventHandling` and `Test_SecretsWorker` are failing consistently, indicating potential issues with the test logic or the code being tested.

Suggested fix: Investigate the root cause of the test failures and fix the underlying issues in the test logic or the code being tested.

3. Condition never satisfied:[Run tests]

Source of Error:

workflow_syncer_test.go:300: 
	Error Trace:	/home/runner/work/chainlink/chainlink/core/services/relay/evm/capabilities/workflows/syncer/workflow_syncer_test.go:300
	Error: 	Condition never satisfied
	Test: 	Test_RegistrySyncer_EventHandling

**Why**: The test `Test_RegistrySyncer_EventHandling` contains a condition that is never met, causing the test to fail.

Suggested fix: Review the condition in the test and ensure it is correctly set up to be satisfied under the expected circumstances. Adjust the test logic or the code being tested as necessary.

4. Uncommitted changes after generate:[Ensure clean after generate]

Source of Error:

.../workflows/syncer/contract_reader_mock.go | 91 ++++++++++++++++++++++
1 file changed, 91 insertions(+)

**Why**: There are uncommitted changes in the file `contract_reader_mock.go` after running the generate command, indicating that the code generation step is not idempotent.

Suggested fix: Ensure that the code generation step produces consistent results and commit any necessary changes to the repository.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

[github-actions]

Flakeguard Summary

Setting	Value
Project	github.com/smartcontractkit/chainlink/v2
Max Pass Ratio	100.00%
Test Run Count	3
Race Detection	false
Excluded Tests	TestChainComponents

Found Flaky Tests ❌

Category	Total
Tests	3
Panicked Tests	0
Raced Tests	0
Flaky Tests	2
Flaky Test Ratio	66.66%
Runs	9
Passes	3
Failures	6
Skips	0
Pass Ratio	33.33%

Name	Pass Ratio	Panicked?	Timed Out?	Race?	Runs	Successes	Failures	Skips	Package	Package Panicked?	Avg Duration	Code Owners
Test_RegistrySyncer_EventHandling	0.00%	false	false	false	3	0	3	0	github.com/smartcontractkit/chainlink/v2/core/services/relay/evm/capabilities/workflows/syncer	false	15.17s	Unknown
Test_SecretsWorker	0.00%	false	false	false	3	0	3	0	github.com/smartcontractkit/chainlink/v2/core/services/relay/evm/capabilities/workflows/syncer	false	15.193333333s	Unknown