Static link token #15546
Merged
Static link token #15546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flakeguard Summary
Found Flaky Tests ❌
|
Flakeguard Summary
Found Flaky Tests ❌
|
AnieeG
reviewed
Dec 6, 2024
deployment/address_book.go
Outdated
| if wantType == haveType { | ||
| counts[wantType]++ | ||
| if counts[wantType] > 1 { | ||
| return false, fmt.Errorf("found more than one instance of a contract") |
There was a problem hiding this comment.
can we show the type in error message?
Wdyt about using multierror and showing all types which will have more than one instance?
There was a problem hiding this comment.
type for sure. multierr maybe bit overkill
AnieeG
approved these changes
Dec 6, 2024
krehermann
approved these changes
Dec 6, 2024
| // and has a distinct ABI from the new LinkToken. | ||
| // Corresponds to the ABI | ||
| // https://github.com/smartcontractkit/chainlink/blob/develop/core/gethwrappers/generated/link_token_interface/link_token_interface.go#L34 | ||
| StaticLinkToken deployment.ContractType = "StaticLinkToken" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting viewing non-B/M link token. Side quest backfilling some tests and improving input validation.