[Keystone][Deployments] Refactor RegisterDONs() #15534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bolekk
commented
Dec 5, 2024
bolekk
commented
- Make it ordered.
- Pass the F value in the request.
krehermann
previously approved these changes
Dec 5, 2024
vyzaldysanchez
previously approved these changes
Dec 5, 2024
bolekk
dismissed stale reviews from vyzaldysanchez and krehermann
via
acbfa5d
bolekk
force-pushed
the
KD-603-add-dons-refactor
branch
from
c98b8c8 to
acbfa5d
Compare
krehermann
previously approved these changes
Dec 5, 2024
1. Make it ordered. 2. Pass the F value in the request.
bolekk
force-pushed
the
KD-603-add-dons-refactor
branch
from
acbfa5d to
69fd773
Compare
vyzaldysanchez
approved these changes
Dec 6, 2024
krehermann
approved these changes
Dec 6, 2024
jhweintraub
pushed a commit
that referenced
this pull request
Dec 6, 2024
1. Make it ordered. 2. Pass the F value in the request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.