support mcms in forwarder contract config changeset #15533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krehermann
commented
Dec 5, 2024
| // Depreciated: use changeset.ConfigureOCR3Contract instead | ||
| // ocr3 contract on the registry chain for the wf dons | ||
| func ConfigureOCR3Contract(env *deployment.Environment, chainSel uint64, dons []RegisteredDon, addrBook deployment.AddressBook, cfg *OracleConfigWithSecrets) error { |
There was a problem hiding this comment.
fix up old signature; addr book now in env
krehermann
commented
Dec 5, 2024
| }, nil | ||
| } | ||
|
|
||
| // ConfigureForwardContracts configures the forwarder contracts on all chains for the given DONS | ||
| // the address book is required to contain the an address of the deployed forwarder contract for every chain in the environment | ||
| func ConfigureForwardContracts(env *deployment.Environment, dons []RegisteredDon, addrBook deployment.AddressBook) error { |
There was a problem hiding this comment.
code mv'ed to forwarder_deployer
krehermann
commented
Dec 5, 2024
| AddressBook: addrBook, | ||
| }, | ||
| DonInfos: donsResp.donInfos, | ||
| Changeset: &deployment.ChangesetOutput{}, // no new addresses, proposals etc |
There was a problem hiding this comment.
fix up old bug; should only return new addresses
krehermann
commented
Dec 5, 2024
| RegistryChainSel uint64 | ||
| } | ||
|
|
||
| func NewRegisteredDon(env deployment.Environment, cfg RegisteredDonConfig) (*RegisteredDon, error) { |
There was a problem hiding this comment.
so we can create the needed input to ConfigureForwarderContracts for a given env
krehermann
changed the title
bolekk
approved these changes
Dec 6, 2024
vyzaldysanchez
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds mcms support to forwarder contract configuration
Requires
Supports