Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit for RMN Home config changeset #15525

Merged
merged 11 commits into from
Dec 9, 2024
Merged

Initial commit for RMN Home config changeset #15525

merged 11 commits into from
Dec 9, 2024

Conversation

carte7000
Copy link
Contributor

This PR add 2 changesets to configure the RMNHome contract

The first one allow to set a new config candidate while the other promote the current candidate to the active configuration

Copy link
Contributor

github-actions bot commented Dec 5, 2024

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

Copy link
Contributor

@AnieeG AnieeG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review

deployment/ccip/changeset/cs_update_rmn_config.go Outdated Show resolved Hide resolved
deployment/ccip/changeset/cs_update_rmn_config.go Outdated Show resolved Hide resolved
deployment/ccip/changeset/cs_update_rmn_config.go Outdated Show resolved Hide resolved
deployment/ccip/changeset/cs_update_rmn_config.go Outdated Show resolved Hide resolved
deployment/ccip/changeset/cs_update_rmn_config.go Outdated Show resolved Hide resolved
@carte7000 carte7000 requested a review from makramkd December 6, 2024 18:50
@carte7000 carte7000 requested a review from AnieeG December 9, 2024 13:10
deployment/ccip/changeset/cs_update_rmn_config.go Outdated Show resolved Hide resolved
deployment/ccip/changeset/cs_update_rmn_config.go Outdated Show resolved Hide resolved
deployment/ccip/changeset/cs_update_rmn_config.go Outdated Show resolved Hide resolved
deployment/ccip/changeset/cs_update_rmn_config.go Outdated Show resolved Hide resolved
deployment/ccip/changeset/cs_update_rmn_config.go Outdated Show resolved Hide resolved
deployment/ccip/changeset/cs_update_rmn_config_test.go Outdated Show resolved Hide resolved
@carte7000 carte7000 requested a review from makramkd December 9, 2024 14:44
makramkd
makramkd previously approved these changes Dec 9, 2024
deployment/ccip/changeset/cs_update_rmn_config.go Outdated Show resolved Hide resolved
deployment/ccip/changeset/cs_update_rmn_config.go Outdated Show resolved Hide resolved
deployment/ccip/changeset/cs_update_rmn_config.go Outdated Show resolved Hide resolved
makramkd
makramkd previously approved these changes Dec 9, 2024
@carte7000 carte7000 marked this pull request as ready for review December 9, 2024 17:54
@carte7000 carte7000 requested review from a team as code owners December 9, 2024 17:54
@carte7000 carte7000 added this pull request to the merge queue Dec 9, 2024
Merged via the queue into develop with commit 75f9cf0 Dec 9, 2024
184 checks passed
@carte7000 carte7000 deleted the rmn-changeset branch December 9, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants