Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wiring engine histogram buckets through to beholder Client #15508

Merged
merged 6 commits into from
Dec 6, 2024
Merged

wiring engine histogram buckets through to beholder Client #15508

merged 6 commits into from
Dec 6, 2024

Conversation

patrickhuie19
Copy link
Contributor

@patrickhuie19 patrickhuie19 commented Dec 4, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@patrickhuie19 patrickhuie19 mentioned this pull request Dec 4, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

pkcll
pkcll reviewed Dec 4, 2024
View reviewed changes
core/cmd/shell.go Outdated Show resolved Hide resolved
pkcll
pkcll previously approved these changes Dec 4, 2024
View reviewed changes
@patrickhuie19 patrickhuie19 marked this pull request as ready for review December 4, 2024 19:20
@patrickhuie19 patrickhuie19 requested review from a team as code owners December 4, 2024 19:20
pkcll
pkcll previously approved these changes Dec 4, 2024
View reviewed changes
@patrickhuie19 patrickhuie19 requested a review from a team as a code owner December 5, 2024 14:56
@patrickhuie19 patrickhuie19 requested review from pkcll and bolekk December 6, 2024 01:58
@patrickhuie19 patrickhuie19 added this pull request to the merge queue Dec 6, 2024
Merged via the queue into develop with commit 2ed0c03 Dec 6, 2024
166 of 167 checks passed
@patrickhuie19 patrickhuie19 deleted the feature/KS-592/support-histograms branch December 6, 2024 15:01
jhweintraub pushed a commit that referenced this pull request Dec 6, 2024
@patrickhuie19 @pkcll @jhweintraub
wiring engine histogram buckets through to beholder Client (#15508)
9b494ea 
* wiring engine histogram buckets through to beholder Client

* bumping common

* Move metric views (#15515)

* bumping common

---------

Co-authored-by: Pavel <[email protected]>
bolekk pushed a commit that referenced this pull request Dec 11, 2024
@patrickhuie19 @pkcll @bolekk
wiring engine histogram buckets through to beholder Client (#15508)
31cb374 
* wiring engine histogram buckets through to beholder Client

* bumping common

* Move metric views (#15515)

* bumping common

---------

Co-authored-by: Pavel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkcll pkcll pkcll approved these changes

@vyzaldysanchez vyzaldysanchez vyzaldysanchez approved these changes

@EasterTheBunny EasterTheBunny Awaiting requested review from EasterTheBunny EasterTheBunny is a code owner automatically assigned from smartcontractkit/foundations

@bolekk bolekk Awaiting requested review from bolekk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrickhuie19 @vyzaldysanchez @pkcll