Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new report format "ReportFormatEVMAbiEncodeUnpacked" #15493

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

samsondav
Copy link
Collaborator

@samsondav samsondav commented Dec 3, 2024

Implement support for new report format: ReportFormatEVMAbiEncodeUnpacked. Enables support for DEX-based asset schemas, RWA, market status, funding rate and more

Requires

Supports

Copy link
Contributor

github-actions bot commented Dec 3, 2024

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

Copy link
Contributor

github-actions bot commented Dec 3, 2024

AER Report: CI Core

aer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , GolangCI Lint (.) , Core Tests (go_core_tests) , test-scripts , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , SonarQube Scan , lint

1. Missing go.mod file for chainlink-common dependency: [go_core_race_tests]

Source of Error:
Download Go vendor packages	2025-01-10T20:45:27.6278702Z go: github.com/smartcontractkit/[email protected] (replaced by /Users/sam/code/smartcontractkit/chainlink-common): reading /Users/sam/code/smartcontractkit/chainlink-common/go.mod: open /Users/sam/code/smartcontractkit/chainlink-common/go.mod: no such file or directory
Download Go vendor packages	2025-01-10T20:45:27.6304078Z ##[error]Process completed with exit code 1.

Why: The go.mod file for the chainlink-common dependency is missing, causing the go mod download command to fail.

Suggested fix: Ensure that the go.mod file exists in the specified directory /Users/sam/code/smartcontractkit/chainlink-common.


2. Missing go.mod file for chainlink-common dependency: [go_core_tests_integration]

Source of Error:
Download Go vendor packages	2025-01-10T20:45:12.7663735Z go: github.com/smartcontractkit/[email protected] (replaced by /Users/sam/code/smartcontractkit/chainlink-common): reading /Users/sam/code/smartcontractkit/chainlink-common/go.mod: open /Users/sam/code/smartcontractkit/chainlink-common/go.mod: no such file or directory
Download Go vendor packages	2025-01-10T20:45:12.7687026Z ##[error]Process completed with exit code 1.

Why: The go.mod file for the chainlink-common dependency is missing, causing the go mod download command to fail.

Suggested fix: Ensure that the go.mod file exists in the specified directory /Users/sam/code/smartcontractkit/chainlink-common.


3. Missing go.mod file for chainlink-common dependency: [go_core_ccip_deployment_tests]

Source of Error:
Download Go vendor packages	2025-01-10T20:44:15.8515433Z go: github.com/smartcontractkit/[email protected] (replaced by /Users/sam/code/smartcontractkit/chainlink-common): reading /Users/sam/code/smartcontractkit/chainlink-common/go.mod: open /Users/sam/code/smartcontractkit/chainlink-common/go.mod: no such file or directory
Download Go vendor packages	2025-01-10T20:44:15.8540052Z ##[error]Process completed with exit code 1.

Why: The go.mod file for the chainlink-common dependency is missing, causing the go mod download command to fail.

Suggested fix: Ensure that the go.mod file exists in the specified directory /Users/sam/code/smartcontractkit/chainlink-common.


4. Typecheck errors in head_listener.go and head_tracker.go: [Golang Lint (.)]

Source of Error:
Golang Lint (.)	2025-01-10T20:45:35.0749568Z ##[error]common/headtracker/head_listener.go:140:29: hl.Name undefined (type *headListener[HTH, S, ID, BLOCK_HASH] has no field or method Name) (typecheck)
Golang Lint (.)	2025-01-10T20:45:35.0750813Z 	return map[string]error{hl.Name(): err}
Golang Lint (.)	2025-01-10T20:45:35.0751577Z 	 ^
Golang Lint (.)	2025-01-10T20:45:35.0752937Z ##[error]common/headtracker/head_listener.go:133:6: declared and not used: err (typecheck)
Golang Lint (.)	2025-01-10T20:45:35.0753591Z 	var err error
Golang Lint (.)	2025-01-10T20:45:35.0753875Z 	 ^
Golang Lint (.)	2025-01-10T20:45:35.0755108Z ##[error]common/headtracker/head_listener.go:169:20: blockHeader.IsValid undefined (type HTH has no field or method IsValid) (typecheck)
Golang Lint (.)	2025-01-10T20:45:35.0756016Z 			if !blockHeader.IsValid() {
Golang Lint (.)	2025-01-10T20:45:35.0756436Z 			 ^
Golang Lint (.)	2025-01-10T20:45:35.0757739Z ##[error]common/headtracker/head_listener.go:175:20: blockHeader.HasChainID undefined (type HTH has no field or method HasChainID) (typecheck)
Golang Lint (.)	2025-01-10T20:45:35.0758927Z 			if !blockHeader.HasChainID() || blockHeader.ChainID().String() != chainId.String() {
Golang Lint (.)	2025-01-10T20:45:35.0759571Z 			 ^
Golang Lint (.)	2025-01-10T20:45:35.0760777Z ##[error]common/headtracker/head_listener.go:176:93: blockHeader.ChainID undefined (type HTH has no field or method ChainID) (typecheck)
Golang Lint (.)	2025-01-10T20:45:35.0762215Z 				hl.eng.Panicf("head listener for %s received block header for %s", chainId, blockHeader.ChainID())
Golang Lint (.)	2025-01-10T20:45:35.0764243Z 				 ^
Golang Lint (.)	2025-01-10T20:45:35.0765639Z ##[error]common/headtracker/head_tracker.go:152:22: latestFinalized.IsValid undefined (type HTH has no field or method IsValid) (typecheck)
Golang Lint (.)	2025-01-10T20:45:35.0766530Z 	if !latestFinalized.IsValid() {
Golang Lint (.)	2025-01-10T20:45:35.0766967Z 	 ^
Golang Lint (.)	2025-01-10T20:45:35.0768394Z ##[error]common/headtracker/head_tracker.go:156:61: latestFinalized.BlockNumber undefined (type HTH has no field or method BlockNumber) (typecheck)
Golang Lint (.)	2025-01-10T20:45:35.0769498Z 	latestChain, err := ht.headSaver.Load(ctx, latestFinalized.BlockNumber())
Golang Lint (.)	2025-01-10T20:45:35.0771179Z 	 ^
Golang Lint (.)	2025-01-10T20:45:35.0772717Z ##[error]common/headtracker/head_tracker.go:161:17: latestChain.IsValid undefined (type HTH has no field or method IsValid) (typecheck)
Golang Lint (.)	2025-01-10T20:45:35.0773583Z 	if latestChain.IsValid() {
Golang Lint (.)	2025-01-10T20:45:35.0773971Z 	 ^
Golang Lint (.)	2025-01-10T20:45:35.0775427Z ##[error]common/headtracker/head_tracker.go:162:27: latestChain.EarliestHeadInChain undefined (type HTH has no field or method EarliestHeadInChain) (typecheck)
Golang Lint (.)	2025-01-10T20:45:35.0776483Z 		earliest := latestChain.EarliestHeadInChain()
Golang Lint (.)	2025-01-10T20:45:35.0777030Z 		 ^
Golang Lint (.)	2025-01-10T20:45:35.0778325Z ##[error]common/headtracker/head_tracker.go:165:38: latestChain.BlockNumber undefined (type HTH has no field or method BlockNumber) (typecheck)
Golang Lint (.)	2025-01-10T20:45:35.0779633Z 			"latest_blockNumber", latestChain.BlockNumber(),
Golang Lint (.)	2025-01-10T20:45:35.0780311Z 			 ^
Golang Lint (.)	2025-01-10T20:45:35.0781793Z ##[error]common/headtracker/head_tracker.go:166:36: latestChain.BlockHash undefined (type HTH has no field or method BlockHash) (typecheck)
Golang Lint (.)	2025-01-10T20:45:35.0782881Z 			"latest_blockHash", latestChain.BlockHash(),
Golang Lint (.)	2025-01-10T20:45:35.0783517Z 			 ^
Golang Lint (.)	2025-01-10T20:45:35.0784849Z ##[error]common/headtracker/head_tracker.go:188:22: latestFinalized.IsValid undefined (type HTH has no field or method IsValid) (typecheck)
Golang Lint (.)	2025-01-10T20:45:35.0785735Z 	if !latestFinalized.IsValid() {
Golang Lint (.)	2025-01-10T20:45:35.0786171Z 	 ^
Golang Lint (.)	2025-01-10T20:45:35.0787471Z ##[error]common/headtracker/head_tracker.go:192:19: headWithChain.BlockNumber undefined (type HTH has no field or method BlockNumber) (typecheck)
Golang Lint (.)	2025-01-10T20:45:35.0788528Z 	if headWithChain.BlockNumber() < latestFinalized.BlockNumber() {
Golang Lint (.)	2025-01-10T20:45:35.0789096Z 	 ^
Golang Lint (.)	2025-01-10T20:45:35.0790380Z ##[error]common/headtracker/head_tracker.go:194:47: headWithChain.BlockNumber undefined (type HTH has no field or method BlockNumber) (typecheck)
Golang Lint (.)	2025-01-10T20:45:35.0791595Z 		ht.log.With("head_block_num", headWithChain.BlockNumber(),
Golang Lint (.)	2025-01-10T20:45:35.0792447Z 		 ^
Golang Lint (.)	2025-01-10T20:45:35.0793933Z ##[error]common/headtracker/head_tracker.go:195:53: latestFinalized.BlockNumber undefined (type HTH has no field or method BlockNumber) (typecheck)
Golang Lint (.)	2025-01-10T20:45:35.0795035Z 			"latest_finalized_block_number", latestFinalized.BlockNumber()).
Golang Lint (.)	2025-01-10T20:45:35.0796003Z 			 ^
Golang Lint (.)	2025-01-10T20:45:35.0797386Z ##[error]common/headtracker/head_tracker.go:200:19: headWithChain.BlockNumber undefined (type HTH has no field or method BlockNumber) (typecheck)
Golang Lint (.)	2025-01-10T20:45:35.0798722Z 	if headWithChain.BlockNumber()-latestFinalized.BlockNumber() > int64(ht.htConfig.MaxAllowedFinalityDepth()) {
Golang Lint (.)	2025-01-10T20:45:35.0799516Z 	 ^
Golang Lint (.)	2025-01-10T20:45:35.0800841Z ##[error]common/headtracker/head_tracker.go:202:20: latestFinalized.BlockNumber undefined (type HTH has no field or method BlockNumber) (typecheck)
Golang Lint (.)	2025-01-10T20:45:35.0802359Z 			latestFinalized.BlockNumber(), headWithChain.BlockNumber(), ht.htConfig.MaxAllowedFinalityDepth())
Golang Lint (.)	2025-01-10T20:45:35.0803129Z 			 ^
Golang Lint (.)	2025-01-10T20:45:35.0804354Z ##[error]common/headtracker/head_tracker.go:215:57: head.BlockNumber undefined (type HTH has no field or method BlockNumber) (typecheck)
Golang Lint (.)	2025-01-10T20:45:35.0805357Z 	ht.log.Debugw(fmt.Sprintf("Received new head %v", head.BlockNumber()),
Golang Lint (.)	2025-01-10T20:45:35.0806413Z 	 ^
Golang Lint (.)	2025-01-10T20:45:35.0807646Z ##[error]common/headtracker/head_tracker.go:216:21: head.BlockHash undefined (type HTH has no field or method BlockHash) (typecheck)
Golang Lint (.)	2025-01-10T20:45:35.0808513Z 		"blockHash", head.BlockHash(),
Golang Lint (.)	2025-01-10T20:45:35.0808935Z 		 ^
Golang Lint (.)	2025-01-10T20:45:35.0810163Z ##[error]common/headtracker/head_tracker.go:217:26: head.GetParentHash undefined (type HTH has no field or method GetParentHash) (typecheck)
Golang Lint (.)	2025-01-10T20:45:35.0811501Z 		"parentHeadHash", head.GetParentHash(),
Golang Lint (.)	2025-01-10T20:45:35.0812032Z 		 ^
Golang Lint (.)	2025-01-10T20:45:35.0813315Z ##[error]common/headtracker/head_tracker.go:218:19: head.GetTimestamp undefined (type HTH has no field or method GetTimestamp) (typecheck)
Golang Lint (.)	2025-01-10T20:45:35.0814184Z 		"blockTs", head.GetTimestamp(),
Golang Lint (.)	2025-01-10T20:45:35.0814603Z 		 ^
Golang Lint (.)	2025-01-10T20:45:35.0815812Z ##[error]common/headtracker/head_tracker.go:219:23: head.GetTimestamp undefined (type HTH has no field or method GetTimestamp) (typecheck)
Golang Lint (.)	2025-01-10T20:45:35.0816721Z 		"blockTsUnix", head.GetTimestamp().Unix(),
Golang Lint (.)	2025-01-10T20:45:35.0817439Z 		 ^
Golang Lint (.)	2025-01-10T20:45:35.0818745Z ##[error]common/headtracker/head_tracker.go:220:27: head.BlockDifficulty undefined (type HTH has no field or method BlockDifficulty) (typecheck)
Golang Lint (.)	2025-01-10T20:45:35.0819674Z 		"blockDifficulty", head.BlockDifficulty(),
Golang Lint (.)	2025-01-10T20:45:35.0820198Z 		 ^
Golang Lint (.)	2025-01-10T20:45:35.0821619Z ##[error]common/headtracker/head_tracker.go:229:15: prevHead.IsValid undefined (type HTH has no field or method IsValid) (typecheck)
Golang Lint (.)	2025-01-10T20:45:35.0822647Z 	if !prevHead.IsValid() || head.BlockNumber() > prevHead.BlockNumber() {
Golang Lint (.)	2025-01-10T20:45:35.0823198Z 	 ^
Golang Lint (.)	2025-01-10T20:45:35.0824404Z ##[error]common/headtracker/head_tracker.go:230:73: head.BlockNumber undefined (type HTH has no field or method BlockNumber) (typecheck)
Golang Lint (.)	2025-01-10T20:45:35.0825547Z 		promCurrentHead.WithLabelValues(ht.chainID.String()).Set(float64(head.BlockNumber()))
Golang Lint (.)	2025-01-10T20:45:35.0827046Z 		 ^
Golang Lint (.)	2025-01-10T20:45:35.0828340Z ##[error]common/headtracker/head_tracker.go:232:44: head.BlockHash undefined (type HTH has no field or method BlockHash) (typecheck)
Golang Lint (.)	2025-01-10T20:45:35.0829278Z 		headWithChain := ht.headSaver.Chain(head.BlockHash())
Golang Lint (.)	2025-01-10T20:45:35.0830051Z 		
</cicore>
  
    




<operatoruici>

## AER Report: [Operator UI CI](https://github.com/smartcontractkit/chainlink/actions/runs/12716923126) ran successfully :white_check_mark:

[aer_workflow](https://github.com/smartcontractkit/chainlink/actions/runs/12716936265/job/35452324258) , [commit](https://github.com/smartcontractkit/chainlink/commit/65700b25d27d00ae48beaa900804b96660b7b105)

</operatoruici>

@samsondav samsondav force-pushed the MERC-6652-parallel-comp-llo-support-for-new-report-format-evm-abi-encode-unpacked-to-support-flexible-schemas branch from 6706cd3 to ec1c464 Compare December 4, 2024 18:07
@samsondav samsondav force-pushed the MERC-6652-parallel-comp-llo-support-for-new-report-format-evm-abi-encode-unpacked-to-support-flexible-schemas branch 3 times, most recently from c6aae18 to 0402038 Compare January 10, 2025 20:34
@samsondav samsondav force-pushed the MERC-6652-parallel-comp-llo-support-for-new-report-format-evm-abi-encode-unpacked-to-support-flexible-schemas branch from 0402038 to 65700b2 Compare January 10, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant