Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCIP gethwrappers with zkstack support (integrated with main flow) #15487
base: develop
Are you sure you want to change the base?
CCIP gethwrappers with zkstack support (integrated with main flow) #15487
Changes from 29 commits
f2c6a91
4d31dea
0bf13d1
26eb91e
058da9c
44912a2
c58d1cf
78a9d08
8d21f2e
74d46ad
79539d1
10128e9
a3c61ab
03a4a7a
4b73bd3
4697679
28bb116
fa1e1b2
118ec38
1cd6ec8
b0957f2
cb4d6e4
311ee9a
f46568d
9f16729
ceae356
a4c6d33
dce6eac
5359428
11bfbca
86eaefe
a0775fc
66eb8ec
c2927bb
1413c61
e75485d
d8ff804
20c7c2e
c7788f7
1079efe
0a2425d
cc40fa4
6873664
4d1c29d
aa868d5
6cc2be5
fe7c5be
1188149
9c4d285
ff6bdff
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the overwrite same as the "mode"?
& any other option to provide "fallback_to_optimizing_for_size"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think unless you dont specify this flag, it should be false.
--overwrite
is for overwriting a file if the wrapper already existsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can completely exclude these test contracts? no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, what is the error here? something we can fix? or is this file not being used by any contract?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It compiles
but does not generate the ICCIPEncodingUtils binary
Check failure on line 474 in core/gethwrappers/abigen.go
GitHub Actions / lint
Check failure on line 529 in core/gethwrappers/abigen.go
GitHub Actions / lint
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.