-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TT-1862] remove logstream #15465
Merged
Merged
[TT-1862] remove logstream #15465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…some tolerated critical messages to CCIP tests
I see you updated files related to
|
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
Tofel
force-pushed
the
tt_1862_remove_logstream
branch
from
December 9, 2024 10:10
410e522
to
726a0b3
Compare
mateusz-sekara
previously approved these changes
Dec 10, 2024
kalverra
previously approved these changes
Dec 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Dec 10, 2024
kalverra
previously approved these changes
Dec 10, 2024
b-gopalswami
previously approved these changes
Dec 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 10, 2024
mateusz-sekara
approved these changes
Dec 11, 2024
skudasov
approved these changes
Dec 11, 2024
b-gopalswami
approved these changes
Dec 11, 2024
erikburt
approved these changes
Dec 11, 2024
anirudhwarrier
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we remove
logstream
since we cannot stream logs to Loki anyway anymore (and in the future we will use a different solution for doing it). Now we will just dump all Docker container logs to files using Docker API, and then upload these files as artifacts, if the test failed.This vastly simplifies our code :-)