Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RMN integration test updates #15423

Merged
merged 15 commits into from
Nov 29, 2024
Merged

RMN integration test updates #15423

merged 15 commits into from
Nov 29, 2024

Conversation

dimkouv
Copy link
Contributor

@dimkouv dimkouv commented Nov 26, 2024 •
edited
Loading

  • Re-configure and enable the disabled test cases in CI.
  • Add cursing related integration tests (no issues found).
  • Refactor the test, split testCase runner body into functions.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 26, 2024 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@dimkouv dimkouv changed the title enable rmn tests RMN integration test updates Nov 28, 2024
@dimkouv dimkouv marked this pull request as ready for review November 28, 2024 12:08
@dimkouv dimkouv requested review from a team as code owners November 28, 2024 12:08
@dimkouv dimkouv enabled auto-merge November 28, 2024 12:15
patrickhuie19
patrickhuie19 previously approved these changes Nov 28, 2024
View reviewed changes
makramkd
makramkd requested changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@makramkd makramkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the cursing logic as written is 100% correct, but lmk if I'm wrong and we can figure this out

integration-tests/smoke/ccip/ccip_rmn_test.go Show resolved Hide resolved
integration-tests/smoke/ccip/ccip_rmn_test.go Outdated Show resolved Hide resolved
integration-tests/smoke/ccip/ccip_rmn_test.go Show resolved Hide resolved
integration-tests/smoke/ccip/ccip_rmn_test.go Outdated Show resolved Hide resolved
integration-tests/smoke/ccip/ccip_rmn_test.go Show resolved Hide resolved
integration-tests/smoke/ccip/ccip_rmn_test.go Outdated Show resolved Hide resolved
@dimkouv dimkouv dismissed stale reviews from patrickhuie19 and mateusz-sekara via 9b12955 November 29, 2024 14:05
@dimkouv dimkouv added this pull request to the merge queue Nov 29, 2024
Merged via the queue into develop with commit 2ca1a09 Nov 29, 2024
179 checks passed
@dimkouv dimkouv deleted the dk/enable-rmn-tests branch November 29, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tofel Tofel Tofel approved these changes

@makramkd makramkd makramkd approved these changes

@cedric-cordenier cedric-cordenier Awaiting requested review from cedric-cordenier cedric-cordenier is a code owner automatically assigned from smartcontractkit/foundations

@winder winder Awaiting requested review from winder winder is a code owner automatically assigned from smartcontractkit/ccip-offchain

@rstout rstout Awaiting requested review from rstout rstout is a code owner automatically assigned from smartcontractkit/ccip-offchain

@asoliman92 asoliman92 Awaiting requested review from asoliman92 asoliman92 is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xAustinWang 0xAustinWang Awaiting requested review from 0xAustinWang 0xAustinWang is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xnogo 0xnogo Awaiting requested review from 0xnogo 0xnogo is a code owner automatically assigned from smartcontractkit/ccip-offchain

@patrickhuie19 patrickhuie19 Awaiting requested review from patrickhuie19

@mateusz-sekara mateusz-sekara Awaiting requested review from mateusz-sekara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dimkouv @makramkd @patrickhuie19 @mateusz-sekara @Tofel