Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add legacy fallback to RMNRemote #15422

Merged

Conversation

RensR
Copy link
Contributor

@RensR RensR commented Nov 26, 2024

No description provided.

@RensR RensR requested a review from a team as a code owner November 26, 2024 14:59
@RensR RensR requested review from a team as code owners November 26, 2024 16:20
@smartcontractkit smartcontractkit deleted a comment from github-actions bot Nov 26, 2024
@smartcontractkit smartcontractkit deleted a comment from github-actions bot Nov 26, 2024
@smartcontractkit smartcontractkit deleted a comment from github-actions bot Nov 26, 2024
Copy link
Contributor

github-actions bot commented Nov 26, 2024

Solidity Review Jira issue

Hey! We have taken the liberty to link this PR to a Jira issue for Solidity Review.

This is a new feature, that's currently in the pilot phase, so please make sure that the linkage is correct. In a contrary case, please update it manually in JIRA and replace Solidity Review issue key in the changeset file with the correct one.
Please reach out to the Test Tooling team and notify them about any issues you encounter.

Any changes to the Solidity Review Jira issue should be reflected in the changeset file. If you need to update the issue key, please do so manually in the following changeset file: contracts/.changeset/bright-jokes-kiss.md

This PR has been linked to Solidity Review Jira issue: CCIP-3966

Copy link
Contributor

github-actions bot commented Nov 26, 2024

Static analysis results are available

Hey @RensR, you can view Slither reports in the job summary here or download them as artifact here.
Please check them before merging and make sure you have addressed all issues.

Copy link
Contributor

@makramkd makramkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@@ -7,9 +7,10 @@ import (
"github.com/ethereum/go-ethereum/accounts/abi/bind"
"github.com/ethereum/go-ethereum/common"
"github.com/ethereum/go-ethereum/common/hexutil"
cciptypes "github.com/smartcontractkit/chainlink-ccip/pkg/types/ccipocr3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@RensR RensR force-pushed the CCIP-4261-rmn-remote-backwards-compatibility-with-is-blessed branch from 0a5640f to ed17518 Compare December 2, 2024 15:04
@RensR RensR enabled auto-merge December 3, 2024 10:14
@RensR RensR added this pull request to the merge queue Dec 3, 2024
@RensR RensR disabled auto-merge December 3, 2024 15:04
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 3, 2024
@RensR RensR added this pull request to the merge queue Dec 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 3, 2024
@RensR RensR added this pull request to the merge queue Dec 3, 2024
Merged via the queue into develop with commit 3cecd5f Dec 3, 2024
201 of 202 checks passed
@RensR RensR deleted the CCIP-4261-rmn-remote-backwards-compatibility-with-is-blessed branch December 3, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants