-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testing #15380
base: develop
Are you sure you want to change the base?
testing #15380
Conversation
@@ -237,3 +238,51 @@ func GenerateOCR3Config(cfg OracleConfigWithSecrets, nca []NodeKeys) (OCR2Oracle | |||
|
|||
return config, nil | |||
} | |||
|
|||
type configureOCR3Request struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code mv
@@ -0,0 +1,262 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
combination of state.json in and manual fixes for bug and 574
) | ||
|
||
var wantOCR3Config = `{ | ||
"Signers": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lifted from testdata output
dryRun bool | ||
} | ||
|
||
func (r configureOCR3Request) generateOCR3Config() (OCR2OracleConfig, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extract to test vs testdata data
require.NoError(t, err) | ||
|
||
ocrCfg := deployment.OCRConfig{ | ||
KeyBundleID: ocrKey.KeyBundleID, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe something is wrong here and causes the bad encoding in the test failure?
Requires
Supports