Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parallel Comp (LLO) cleanup and minor optimizations #15368

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Parallel Comp (LLO) cleanup and minor optimizations #15368

wants to merge 4 commits into from

Conversation

samsondav
Copy link
Collaborator

@samsondav samsondav commented Nov 21, 2024 •
edited
Loading 

- Add ChannelDefinitionCacheFactory tests
- Cleanup TODOs/FIXMEs
- Add comments/docs
- Include Don ID in LLO extra hash
- Optimize log poller calls

@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@samsondav samsondav changed the title Add ChannelDefinitionCacheFactory tests Add ChannelDefinitionCacheFactory tests; further clean up LLO code; misc improvements/fixes Nov 22, 2024
@samsondav samsondav marked this pull request as ready for review November 25, 2024 15:21
@samsondav samsondav requested review from a team as code owners November 25, 2024 15:21
@samsondav samsondav changed the title Add ChannelDefinitionCacheFactory tests; further clean up LLO code; misc improvements/fixes Parallel Comp (LLO) cleanup and minor optimizations Nov 25, 2024
pavel-raykov
pavel-raykov reviewed Nov 25, 2024
View reviewed changes
core/services/relay/evm/llo/config_poller.go
exprs := []query.Expression{
logpoller.NewAddressFilter(addr),
query.Or(
logpoller.NewEventSigFilter(ProductionConfigSet),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, is it really hardcoded in the code that the types can be ProductionConfigSet and StagingConfigSet? If yes, how production (as type) is different from the staging?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is hardcoded. Events are defined here: https://github.com/smartcontractkit/chainlink/blob/develop/contracts/src/v0.8/llo-feeds/v0.5.0/configuration/interfaces/IConfigurator.sol

jmank88
jmank88 previously approved these changes Nov 25, 2024
View reviewed changes
@samsondav
Parallel Comp (LLO) cleanup and minor optimizations
4321e0e 
- Add ChannelDefinitionCacheFactory tests
- Cleanup TODOs/FIXMEs
- Add comments/docs
- Include Don ID in LLO extra hash
- Optimize log poller calls
pavel-raykov
pavel-raykov previously approved these changes Nov 25, 2024
View reviewed changes
pavel-raykov
pavel-raykov previously approved these changes Nov 25, 2024
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msuchacz-cll msuchacz-cll msuchacz-cll approved these changes

@jmank88 jmank88 Awaiting requested review from jmank88

@pavel-raykov pavel-raykov Awaiting requested review from pavel-raykov

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samsondav @jmank88 @pavel-raykov @msuchacz-cll