Refactor secondary transmission

[george-dorin]

No description provided.

[github-actions]

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

• #added For any new functionality added.
• #breaking_change For any functionality that requires manual action for the node to boot.
• #bugfix For bug fixes.
• #changed For any change to the existing functionality.
• #db_update For any feature that introduces updates to database schema.
• #deprecation_notice For any upcoming deprecation functionality.
• #internal For changesets that need to be excluded from the final changelog.
• #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
• #removed For any functionality/config that is removed.
• #updated For any functionality that is updated.
• #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

[github-actions]

AER Report: CI Core

aer_workflow , commit , Detect Changes , Scheduled Run Frequency , Clean Go Tidy & Generate , Find New Flaky Tests In Chainlink Project / Get Tests To Run , lint , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Find New Flaky Tests In Deployment Project , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Find New Flaky Tests In Chainlink Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/services/relay/evm, ubuntu-latest) , Find New Flaky Tests In Chainlink Project / Report , Flakey Test Detection , SonarQube Scan

1. Comment formatting issue: Golang Lint

Source of Error:

core/services/relay/evm/contract_transmitter.go:129:51: commentFormatting: put a space between `//` and comment text (gocritic)
dualTransmissionABI: initDualTransmissionABI(), //TODO @george-dorin: Remove when contracts are merged

Why: The comment //TODO @george-dorin: Remove when contracts are merged does not have a space between // and the comment text, which violates the gocritic linter rule for comment formatting.

Suggested fix: Add a space between // and TODO to follow the proper comment formatting convention.

2. Non-wrapping format verb: Golang Lint

Source of Error:

core/services/relay/evm/contract_transmitter.go:106:64: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
panic(fmt.Errorf("failed to parse dualTransmission ABI: %v", err))

Why: The fmt.Errorf function is used with %v to format an error, but %w should be used to wrap the error according to the errorlint linter rule.

Suggested fix: Replace %v with %w in the fmt.Errorf call to properly wrap the error.

3. Test failures: Run tests

Source of Error:

Run tests 2024-11-21T18:02:33.8585278Z Failed tests and panics: ---------------------
Run tests 2024-11-21T18:02:33.8585776Z 
Run tests 2024-11-21T18:11:18.0493194Z 
Run tests 2024-11-21T18:11:18.0494326Z ----------------------------------------------
Run tests 2024-11-21T18:11:18.0496711Z 
Run tests 2024-11-21T18:11:18.0497411Z Beginning check of output logs for sensitive strings
Run tests 2024-11-21T18:11:18.1096654Z No matches in test log output against known set of sensitive strings
Run tests 2024-11-21T18:11:18.1098533Z Exit code: 1
Run tests 2024-11-21T18:11:18.1099282Z Encountered test failures.
Run tests 2024-11-21T18:11:18.1099938Z go_core_tests exiting with code 1
Run tests 2024-11-21T18:11:18.1119903Z ##[error]Process completed with exit code 1.

Why: The test suite encountered one or more test failures or panics, which caused the go_core_tests job to exit with a non-zero status code.

Suggested fix: Review the test output logs to identify the specific tests that failed or caused panics, and address the underlying issues in the code or tests.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

[github-actions]

Flaky Test Detector for github.com/smartcontractkit/chainlink project has failed ❌

Ran new or updated tests between develop and a916513 (update-secondary-transmission-method-signature).

View Flaky Detector Details | Compare Changes

Flaky Tests

Ran 69 unique tests. Below are the tests identified as flaky, with a pass ratio lower than the 99% threshold:

TestPackage                                                       TestName                             PassRatio  RunCount   Skipped
---------                                                         ---------                            ---------  ---------  ---------
github.com/smartcontractkit/chainlink/v2/core/services/relay/evm  Test_OCRContractTracker_IsLaterThan  50%        3          false