Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evm implementation of contract reader query keys API #15336

Merged
merged 4 commits into from
Dec 9, 2024
Merged

evm implementation of contract reader query keys API #15336

merged 4 commits into from
Dec 9, 2024

Conversation

ettec
Copy link
Collaborator

@ettec ettec commented Nov 20, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 20, 2024 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@ettec ettec force-pushed the query-keys-api branch 3 times, most recently from 3ebb80e to 24a7c6d Compare November 26, 2024 10:12
@ettec ettec marked this pull request as ready for review November 26, 2024 11:44
@ettec ettec requested review from a team as code owners November 26, 2024 11:44
@ettec ettec requested a review from krehermann November 26, 2024 11:44
ilija42
ilija42 reviewed Nov 26, 2024
View reviewed changes
Copy link
Contributor

@ilija42 ilija42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach seems fine, would be nice to have some tests that test new unique scenarios not found with QueryKey

@ettec ettec force-pushed the query-keys-api branch 5 times, most recently from 335b96c to 7596a95 Compare November 27, 2024 22:27
@ettec ettec force-pushed the query-keys-api branch 2 times, most recently from 7007356 to b48bf21 Compare December 6, 2024 10:16
@ettec ettec changed the title spike on query keys evm implementation of contract reader query keys API Dec 6, 2024
cedric-cordenier
cedric-cordenier previously approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@cedric-cordenier cedric-cordenier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'll defer to the chain reader folks for an in-depth review of the logic as I have limited context on chainreader.

EasterTheBunny
EasterTheBunny previously approved these changes Dec 6, 2024
View reviewed changes
@ettec ettec dismissed stale reviews from EasterTheBunny and cedric-cordenier via 4829aca December 7, 2024 16:22
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Flakeguard Summary

Setting Value
Project github.com/smartcontractkit/chainlink/v2
Max Pass Ratio 100.00%
Test Run Count 3
Race Detection false
Excluded Tests TestChainComponents

Found Flaky Tests ❌

Category Total
Tests 25
Panicked Tests 0
Raced Tests 0
Flaky Tests 2
Flaky Test Ratio 8.00%
Runs 69
Passes 63
Failures 6
Skips 0
Pass Ratio 91.30%
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestValidateEventQueries 0.00% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/relay/evm/read false 0s Unknown
TestValidateEventQueries/duplicate_event_query 0.00% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/relay/evm/read false 0s Unknown

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Flakeguard Summary

Setting Value
Project github.com/smartcontractkit/chainlink/v2
Max Pass Ratio 100.00%
Test Run Count 3
Race Detection false
Excluded Tests TestChainComponents

Found Flaky Tests ❌

Category Total
Tests 25
Panicked Tests 0
Raced Tests 0
Flaky Tests 2
Flaky Test Ratio 8.00%
Runs 69
Passes 63
Failures 6
Skips 0
Pass Ratio 91.30%
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestValidateEventQueries 0.00% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/relay/evm/read false 0s Unknown
TestValidateEventQueries/duplicate_event_query 0.00% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/relay/evm/read false 0s Unknown

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Flakeguard Summary

Setting Value
Project github.com/smartcontractkit/chainlink/v2
Max Pass Ratio 100.00%
Test Run Count 3
Race Detection false
Excluded Tests TestChainComponents

Found Flaky Tests ❌

Category Total
Tests 25
Panicked Tests 0
Raced Tests 0
Flaky Tests 2
Flaky Test Ratio 8.00%
Runs 69
Passes 63
Failures 6
Skips 0
Pass Ratio 91.30%
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestValidateEventQueries 0.00% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/relay/evm/read false 0s Unknown
TestValidateEventQueries/duplicate_event_query 0.00% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/relay/evm/read false 0s Unknown

EasterTheBunny
EasterTheBunny previously approved these changes Dec 9, 2024
View reviewed changes
cedric-cordenier
cedric-cordenier approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@cedric-cordenier cedric-cordenier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 in Awbrey's absence

@ettec ettec added this pull request to the merge queue Dec 9, 2024
Merged via the queue into develop with commit 7b7815e Dec 9, 2024
165 of 166 checks passed
@ettec ettec deleted the query-keys-api branch December 9, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilija42 ilija42 ilija42 approved these changes

@cedric-cordenier cedric-cordenier cedric-cordenier approved these changes

@EasterTheBunny EasterTheBunny EasterTheBunny left review comments

@krehermann krehermann Awaiting requested review from krehermann krehermann is a code owner automatically assigned from smartcontractkit/foundations

@dhaidashenko dhaidashenko Awaiting requested review from dhaidashenko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ettec @EasterTheBunny @cedric-cordenier @ilija42