CCIP-4269 - Make registered TokenPools swappable #15293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contracts/src/v0.8/ccip/test/pools/TokenPool/TokenPool.removeRemotePool.t.sol
Show resolved
Hide resolved
matYang
reviewed
Nov 19, 2024
RensR
changed the title
Solidity Review Jira issueHey! We have taken the liberty to link this PR to a Jira issue for Solidity Review. This is a new feature, that's currently in the pilot phase, so please make sure that the linkage is correct. In a contrary case, please update it manually in JIRA and replace Solidity Review issue key in the changeset file with the correct one. Any changes to the Solidity Review Jira issue should be reflected in the changeset file. If you need to update the issue key, please do so manually in the following changeset file: This PR has been linked to Solidity Review Jira issue: CCIP-3966 |
RensR
force-pushed
the
CCIP-4269-make-pools-swappable
branch
from
76fb375 to
f17e34d
Compare
RensR
force-pushed
the
CCIP-4269-make-pools-swappable
branch
from
f17e34d to
1369053
Compare
# Conflicts: # contracts/gas-snapshots/ccip.gas-snapshot # contracts/src/v0.8/ccip/test/pools/TokenPool/TokenPoolSetup.t.sol # contracts/src/v0.8/ccip/test/pools/USDC/HybridLockReleaseUSDCTokenPool/HybridLockReleaseUSDCTokenPool.lockOrBurn.t.sol # contracts/src/v0.8/ccip/test/pools/USDC/HybridLockReleaseUSDCTokenPool/HybridLockReleaseUSDCTokenPool.releaseOrMint.t.sol # contracts/src/v0.8/ccip/test/pools/USDC/HybridLockReleaseUSDCTokenPool/HybridLockReleaseUSDCTokenPool.transferLiquidity.t.sol # contracts/src/v0.8/ccip/test/pools/USDC/USDCBridgeMigrator/USDCBridgeMigrator.burnLockedUSDC.t.sol # contracts/src/v0.8/ccip/test/pools/USDC/USDCBridgeMigrator/USDCBridgeMigrator.cancelMigrationProposal.t.sol # contracts/src/v0.8/ccip/test/pools/USDC/USDCBridgeMigrator/USDCBridgeMigrator.excludeTokensFromBurn.t.sol # contracts/src/v0.8/ccip/test/pools/USDC/USDCBridgeMigrator/USDCBridgeMigrator.proposeMigration.t.sol # contracts/src/v0.8/ccip/test/pools/USDC/USDCBridgeMigrator/USDCBridgeMigrator.provideLiquidity.t.sol # contracts/src/v0.8/ccip/test/pools/USDC/USDCBridgeMigrator/USDCBridgeMigrator.releaseOrMint.t.sol # contracts/src/v0.8/ccip/test/pools/USDC/USDCBridgeMigrator/USDCBridgeMigrator.updateChainSelectorMechanism.t.sol
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
RensR
force-pushed
the
CCIP-4269-make-pools-swappable
branch
from
0647068 to
2519b3f
Compare
* use calldata over memory, extract isRemotePool * support different decimals * pass in decimals * add tests * fix liqman, tests, gen code * fix offchain
|
I see you added a changeset file but it does not contain a tag. Please edit the text include at least one of the following tags:
|
RensR
requested review from
winder,
rstout,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara,
0xnogo and
george-dorin
makramkd
previously approved these changes
Nov 22, 2024
… in constructor (#15337) * support different decimals * pass in decimals * add tests * gen wrappers * update factory contract to use new arbitrary token decimals in constructor * snapshot fix --------- Co-authored-by: Rens Rooimans <[email protected]>
matYang
approved these changes
Nov 22, 2024
makramkd
approved these changes
Nov 22, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
* store hash of (dest chain selector, remote pool) to do lookup * fill in coverage gaps and fix zero address check * remove comment * Update gethwrappers * reduce test code * add test multiple remote pools * improve tests * rename and rm EVM specific checks * [Bot] Update changeset file with jira issues * fix offchain tests * use mapping over set * move remotePools mapping to RemoteChainConfig * use bytes32 set over bytes mapping * fix ci * allow multiple pools on remote chain config * support different decimals (#15310) * use calldata over memory, extract isRemotePool * support different decimals * pass in decimals * add tests * fix liqman, tests, gen code * fix offchain * add comment, changeset and fix lint * turn off 1.4 test * CCIP-4331 update factory contract to use new arbitrary token decimals in constructor (#15337) * support different decimals * pass in decimals * add tests * gen wrappers * update factory contract to use new arbitrary token decimals in constructor * snapshot fix --------- Co-authored-by: Rens Rooimans <[email protected]> --------- Co-authored-by: Rens Rooimans <[email protected]> Co-authored-by: Josh <[email protected]> Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com> Co-authored-by: Josh Weintraub <[email protected]>
This was referenced Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.