Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bind real contracts per chain in CCIPReader test #15282

Merged
merged 6 commits into from
Nov 19, 2024
Merged

Bind real contracts per chain in CCIPReader test #15282

merged 6 commits into from
Nov 19, 2024

Conversation

asoliman92
Copy link
Contributor

@asoliman92 asoliman92 commented Nov 18, 2024 •
edited
Loading

Add functionality to bind more contracts to different chains (using same simulated backend for simplicity) in ccipreader tester.

  • LinkPriceUSD test
  • GetMedianDataAvailabilityGasConfig

@asoliman92 asoliman92 requested a review from a team as a code owner November 18, 2024 14:11
@asoliman92 asoliman92 requested review from winder, rstout, makramkd, dimkouv, mateusz-sekara, 0xAustinWang and 0xnogo and removed request for a team November 18, 2024 14:11
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@github-actions GitHub Actions
Copy link
Contributor

Flaky Test Detector for ./go.mod project has failed ❌

Ran new or updated tests between ccipreader-tests and fc26e33 (link-price-usd).

View Flaky Detector Details | Compare Changes

Failed Tests

Ran 9 tests in total for all affected test packages. Below are the tests identified as flaky, with a pass ratio lower than the 100% threshold:

TestPackage                                                                                        TestName                                 PassRatio  RunCount   Skipped
---------                                                                                          ---------                                ---------  ---------  ---------
github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/ccip_integration_tests/ccipreader  Test_GetMedianDataAvailabilityGasConfig  0%         1          false
github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/ccip_integration_tests/ccipreader  Test_GetChainFeePriceUpdates             0%         1          false
github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/ccip_integration_tests/ccipreader  Test_LinkPriceUSD                        0%         1          false

@asoliman92 asoliman92 merged commit 65546de into ccipreader-tests Nov 19, 2024
152 of 153 checks passed
@asoliman92 asoliman92 deleted the link-price-usd branch November 19, 2024 11:48
github-merge-queue bot pushed a commit that referenced this pull request Nov 20, 2024
@asoliman92
CCIPReader pricing tests (#15264)
47da13e 
* Add Test_GetChainFeePriceUpdates (#15240)

Add Test_GetChainFeePriceUpdates

* Bind real contracts per chain in CCIPReader test (#15282)

Add functionality to bind more contracts to different chains (using same simulated backend for simplicity) in ccipreader tester.

LinkPriceUSD test
GetMedianDataAvailabilityGasConfig

* Test_GetWrappedNativeTokenPriceUSD (#15316)

Test_GetWrappedNativeTokenPriceUSD

* comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateusz-sekara mateusz-sekara mateusz-sekara approved these changes

@winder winder Awaiting requested review from winder winder was automatically assigned from smartcontractkit/ccip-offchain

@rstout rstout Awaiting requested review from rstout rstout was automatically assigned from smartcontractkit/ccip-offchain

@makramkd makramkd Awaiting requested review from makramkd makramkd was automatically assigned from smartcontractkit/ccip-offchain

@dimkouv dimkouv Awaiting requested review from dimkouv dimkouv was automatically assigned from smartcontractkit/ccip-offchain

@0xAustinWang 0xAustinWang Awaiting requested review from 0xAustinWang 0xAustinWang was automatically assigned from smartcontractkit/ccip-offchain

@0xnogo 0xnogo Awaiting requested review from 0xnogo 0xnogo was automatically assigned from smartcontractkit/ccip-offchain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asoliman92 @mateusz-sekara