Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCIP-4160 Token Transfer Tests #15278
CCIP-4160 Token Transfer Tests #15278
Changes from 32 commits
3bfac63
4617621
24dd4f6
8bae382
b4a4a98
25c1b15
94a2527
9be1966
18f5f2e
7f8fd25
3d969d6
e2182dd
8273eac
1bc99b3
e1a80af
691300c
8f4d4c5
36df2f6
faca5a5
211e668
c53e872
1a03b58
9037d57
f829199
eee7c93
947b68d
eedb8fa
8308df9
6b726d7
20a017e
97c74df
7f3fb4f
b870f35
be9e925
c7d3987
d2fa64a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need a ticket to move all these funcs out of
changeset
and into acciptesthelpers
package or something,changeset
is supposed to be the public API and shouldn't have these kinda funcs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe better to pass
ctx
to this func?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
WaitForTokenBalance
without theThe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe pass
ctx
to this func? to avoid getting a new one everyime.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similar for
ctx