fix diff checks #15258
Merged
fix diff checks #15258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
george-dorin
approved these changes
Nov 15, 2024
AER Report: CI Core ran successfully ✅ |
jmank88
requested review from
HenryNguyen5,
kalverra,
a team and
reductionista
and removed request for
a team
kalverra
approved these changes
Nov 18, 2024
HenryNguyen5
approved these changes
Nov 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
cedric-cordenier
pushed a commit
that referenced
this pull request
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
git diffchecks (used to verify tidiness and that generated files are up to date) fail in cases where there are completely new files. This is both due to the files being unstaged as well as the default behavior ofgit diffto be to ignore them. We can callgit add -allfirst, and include the--cachedflag to get the behavior we want.