Add Test_GetChainFeePriceUpdates #15240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asoliman92
requested review from
winder,
rstout,
makramkd,
dimkouv,
mateusz-sekara,
0xAustinWang and
0xnogo
and removed request for
a team
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
Flaky Test Detector for
|
makramkd
reviewed
Nov 15, 2024
contracts/.changeset/odd-maps-fry.md
Outdated
Comment on lines
6
to
8
| evmconfig "github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/configs/evm" | ||
|
|
||
| "github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/fee_quoter" |
| @@ -47,6 +51,10 @@ const ( | |||
| chainD = cciptypes.ChainSelector(4) | |||
| ) | |||
|
|
|||
| var ( | |||
| defaultGasPrice = big.NewInt(1e9) | |||
| []fee_quoter.FeeQuoterTokenTransferFeeConfigArgs{}, | ||
| []fee_quoter.FeeQuoterPremiumMultiplierWeiPerEthArgs{ | ||
| { | ||
| PremiumMultiplierWeiPerEth: 9e17, // 0.9 ETH |
There was a problem hiding this comment.
I think this means 90% and not 0.9ETH cc @0xnogo
There was a problem hiding this comment.
@makramkd I think you are referring to the gasMultiplierWeiPerEth. But here it's the PremiumMultiplierWeiPerEth
There was a problem hiding this comment.
I think this one is set to pay 10% if you are paying with Link token. I think it needs to have 1e18 unit, so what we have here is correct:
// Calculate number of fee tokens to charge.
// Total USD fee is in 36 decimals, feeTokenPrice is in 18 decimals USD for 1e18 smallest token denominations.
// Result of the division is the number of smallest token denominations.
return ((premiumFee * s_premiumMultiplierWeiPerEth[message.feeToken]) + executionCost + dataAvailabilityCost)
/ feeTokenPrice;
executionCost + dataAvailabilityCost => e36
premium (e18) * s_premiumMultiplierWeiPerEth[message.feeToken] (e18) => e36
makramkd
approved these changes
Nov 15, 2024
| @@ -2,6 +2,7 @@ package ccipreader | |||
|
|
|||
| import ( | |||
| "context" | |||
|
|
|||
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 20, 2024
* Add Test_GetChainFeePriceUpdates (#15240) Add Test_GetChainFeePriceUpdates * Bind real contracts per chain in CCIPReader test (#15282) Add functionality to bind more contracts to different chains (using same simulated backend for simplicity) in ccipreader tester. LinkPriceUSD test GetMedianDataAvailabilityGasConfig * Test_GetWrappedNativeTokenPriceUSD (#15316) Test_GetWrappedNativeTokenPriceUSD * comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.