Add beholder metrics on workflow engine #15238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyzaldysanchez
requested review from
bolekk,
patrickhuie19 and
cedric-cordenier
cedric-cordenier
previously approved these changes
Nov 15, 2024
…undant instrumentation
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
patrickhuie19
previously approved these changes
Nov 26, 2024
cedric-cordenier
previously approved these changes
Nov 26, 2024
bolekk
reviewed
Nov 27, 2024
| @@ -1263,7 +1291,7 @@ func NewEngine(ctx context.Context, cfg Config) (engine *Engine, err error) { | |||
| engine = &Engine{ | |||
| cma: cma, | |||
| logger: cfg.Lggr.Named("WorkflowEngine").With("workflowID", cfg.WorkflowID), | |||
| metrics: workflowsMetricLabeler{metrics.NewLabeler().With(platform.KeyWorkflowID, cfg.WorkflowID, platform.KeyWorkflowOwner, cfg.WorkflowOwner, platform.KeyWorkflowName, cfg.WorkflowName)}, | |||
| metrics: workflowsMetricLabeler{metrics.NewLabeler().With(platform.KeyWorkflowID, cfg.WorkflowID, platform.KeyWorkflowOwner, cfg.WorkflowOwner, platform.KeyWorkflowName, cfg.WorkflowName), *em}, | |||
There was a problem hiding this comment.
Maybe an extra nil check for extra safety?
patrickhuie19
approved these changes
Nov 27, 2024
bolekk
approved these changes
Nov 27, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
* Adds metrics on workflow engine * Adds trigger event metric * Removes comment * metrics: execution duration histograms by status and removing now redundant instrumentation * adding step execution time histogram * fixing data race for global instruments * cleanup + fixing tests * renaming vars somehow fixes broken test * removing short circuit in workferForStepRequest if Vertex call fails * nil guard if Vertex errs * updating workflow.name to workflow.hexName and fixing err log --------- Co-authored-by: patrickhuie19 <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
bolekk
pushed a commit
that referenced
this pull request
Dec 11, 2024
* Adds metrics on workflow engine * Adds trigger event metric * Removes comment * metrics: execution duration histograms by status and removing now redundant instrumentation * adding step execution time histogram * fixing data race for global instruments * cleanup + fixing tests * renaming vars somehow fixes broken test * removing short circuit in workferForStepRequest if Vertex call fails * nil guard if Vertex errs * updating workflow.name to workflow.hexName and fixing err log --------- Co-authored-by: patrickhuie19 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds further instrumentation to the engine. Adding labels. Putting workflows running gauge in the heartbeat to remove misleading label association.
Fixes known potential data race observed here: https://github.com/smartcontractkit/chainlink/actions/runs/11983046999/job/33412020087?pr=15238
The histograms are eventually meant to replace the workflows running + workflow execution latency gauges, but require the follow-ups below before the old ones are removed.
Follow-ups:
KS-580, KS-581