Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCIP-4116 restructure tests #15165

Merged
merged 24 commits into from
Nov 11, 2024
Merged

CCIP-4116 restructure tests #15165

merged 24 commits into from
Nov 11, 2024

Conversation

0xsuryansh
Copy link
Member

Test restructuring

@0xsuryansh 0xsuryansh requested a review from a team as a code owner November 8, 2024 12:34
@0xsuryansh 0xsuryansh changed the title Ccip 4116 restructure tests CCIP 4116 restructure tests Nov 8, 2024
@0xsuryansh 0xsuryansh changed the title CCIP 4116 restructure tests CCIP-4116 restructure tests Nov 8, 2024
@0xsuryansh 0xsuryansh requested a review from RensR November 8, 2024 13:57
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Solidity Review Jira issue

Hey! We have taken the liberty to link this PR to a Jira issue for Solidity Review.

This is a new feature, that's currently in the pilot phase, so please make sure that the linkage is correct. In a contrary case, please update it manually in JIRA and replace Solidity Review issue key in the changeset file with the correct one.
Please reach out to the Test Tooling team and notify them about any issues you encounter.

Any changes to the Solidity Review Jira issue should be reflected in the changeset file. If you need to update the issue key, please do so manually in the following changeset file: contracts/.changeset/six-games-drum.md

This PR has been linked to Solidity Review Jira issue: CCIP-3966

) public {
s_pingPong.setCounterpartAddress(counterpartAddress);

assertEq(s_pingPong.getCounterpartAddress(), counterpartAddress);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be a separate file for each of these functions getCounterPartAddress(), getCounterpartChainSelector, and isPaused

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1,8 +1,8 @@
// SPDX-License-Identifier: BUSL-1.1
pragma solidity 0.8.24;

import {FeeQuoter} from "../../FeeQuoter.sol";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FeeQuoter is a top level contract so you don't need a feeQuoter/FeeQuoter folder, just a FeeQuoter one

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xsuryansh 0xsuryansh requested a review from RensR November 11, 2024 09:52
@0xsuryansh 0xsuryansh added this pull request to the merge queue Nov 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 11, 2024
@0xsuryansh 0xsuryansh added this pull request to the merge queue Nov 11, 2024
Merged via the queue into develop with commit 03827b9 Nov 11, 2024
129 checks passed
@0xsuryansh 0xsuryansh deleted the CCIP-4116_Restructure-tests branch November 11, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants