-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCIP-4116 restructure tests #15165
CCIP-4116 restructure tests #15165
Conversation
contracts/src/v0.8/ccip/test/rmn/armProxy/ArmPorxy.setARM.t.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/ccip/test/rmn/armProxy/ARMProxyStandaloneTestSetup.t.sol
Outdated
Show resolved
Hide resolved
Solidity Review Jira issueHey! We have taken the liberty to link this PR to a Jira issue for Solidity Review. This is a new feature, that's currently in the pilot phase, so please make sure that the linkage is correct. In a contrary case, please update it manually in JIRA and replace Solidity Review issue key in the changeset file with the correct one. Any changes to the Solidity Review Jira issue should be reflected in the changeset file. If you need to update the issue key, please do so manually in the following changeset file: This PR has been linked to Solidity Review Jira issue: CCIP-3966 |
) public { | ||
s_pingPong.setCounterpartAddress(counterpartAddress); | ||
|
||
assertEq(s_pingPong.getCounterpartAddress(), counterpartAddress); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be a separate file for each of these functions getCounterPartAddress()
, getCounterpartChainSelector
, and isPaused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
contracts/src/v0.8/ccip/test/capability/CCIPHome/CCIPHome.constructor.t.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/ccip/test/capability/CCIPHome/CCIPHome.constructor.t.sol
Outdated
Show resolved
Hide resolved
…o CCIP-4116_Restructure-tests
@@ -1,8 +1,8 @@ | |||
// SPDX-License-Identifier: BUSL-1.1 | |||
pragma solidity 0.8.24; | |||
|
|||
import {FeeQuoter} from "../../FeeQuoter.sol"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FeeQuoter is a top level contract so you don't need a feeQuoter/FeeQuoter folder, just a FeeQuoter one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test restructuring