add TRON integration #14783
Open
add TRON integration #14783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| func newFrom(reader io.Reader) (Key, error) { | ||
| privKeyECDSA, err := ecdsa.GenerateKey(curve, reader) |
Check failure
Code scanning / CodeQL
Use of insufficient randomness as the key of a cryptographic algorithm High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 25 days ago
To fix the problem, we need to replace the use of the insecure math/rand package with the secure crypto/rand package for generating random numbers. This ensures that the randomness used in cryptographic operations is secure and not predictable.
- Replace the
NewRandReaderFromSeedfunction incore/internal/testutils/keystest/seedable_rand_reader.goto usecrypto/randinstead ofmath/rand. - Update the
MustNewInsecurefunction incore/services/keystore/keys/tronkey/key.goto use the updated secure random reader.
Suggested changeset
2
core/services/keystore/keys/tronkey/key.go
| @@ -7,3 +7,3 @@ | ||
| "fmt" | ||
| "io" | ||
| "github.com/smartcontractkit/chainlink/v2/core/internal/testutils/keystest" | ||
| "math/big" | ||
| @@ -60,4 +60,4 @@ | ||
| // This insecure function is used for testing purposes only | ||
| func MustNewInsecure(reader io.Reader) Key { | ||
| key, err := newFrom(reader) | ||
| func MustNewInsecure() Key { | ||
| key, err := newFrom(&keystest.cryptoRandReader{}) | ||
| if err != nil { |
core/internal/testutils/keystest/seedable_rand_reader.go
Outside changed files
| @@ -4,3 +4,4 @@ | ||
| "io" | ||
| "math/rand" | ||
| "crypto/rand" | ||
| "math/big" | ||
| ) | ||
| @@ -11,3 +12,16 @@ | ||
| func NewRandReaderFromSeed(seed int64) io.Reader { | ||
| return rand.New(rand.NewSource(seed)) | ||
| return &cryptoRandReader{} | ||
| } | ||
|
|
||
| type cryptoRandReader struct{} | ||
|
|
||
| func (r *cryptoRandReader) Read(p []byte) (n int, err error) { | ||
| for i := range p { | ||
| num, err := rand.Int(rand.Reader, big.NewInt(256)) | ||
| if err != nil { | ||
| return 0, err | ||
| } | ||
| p[i] = byte(num.Int64()) | ||
| } | ||
| return len(p), nil | ||
| } |
Copilot is powered by AI and may make mistakes. Always verify output.
cfal
force-pushed
the
add-tron
branch
2 times, most recently
from
782a261 to
ac8eace
Compare
AER Report: CI Coreaer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Core Tests (go_core_tests) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , lint , SonarQube Scan 1. Struct field naming issue: Golang LintSource of Error:core/services/chainlink/relayer_chain_interoperators_test.go:224:3: var-naming: struct field expectedTronRelayerIds should be expectedTronRelayerIDs (revive)
expectedTronRelayerIds []types.RelayID
^Suggested fix: Rename the struct field from 2. Uncommitted changes after generate: Ensure clean after generateSource of Error:Ensure clean after generate 2024-10-17T21:26:24.7408132Z core/services/chainlink/mocks/general_config.go | 54 ++++
Ensure clean after generate 2024-10-17T21:26:24.7409148Z core/services/keystore/mocks/master.go | 27 ++
Ensure clean after generate 2024-10-17T21:26:24.7410460Z core/services/keystore/mocks/tron.go | 362 +++++++++++++++++++-----
Ensure clean after generate 2024-10-17T21:26:24.7411409Z 3 files changed, 371 insertions(+), 72 deletions(-)
Ensure clean after generate 2024-10-17T21:26:24.9829369Z ##[error]Process completed with exit code 1.Suggested fix: Commit the changes made by the generate command to the repository. 3. Invalid configuration: Core Tests (go_core_tests)Source of Error:Print Filtered Test Results 2024-10-17T21:32:03.9988996Z Error running app: invalid configuration: 4 errors:
Print Filtered Test Results 2024-10-17T21:32:03.9989177Z - EVM: 4 errors:
Print Filtered Test Results 2024-10-17T21:32:03.9989595Z - 1.ChainID: invalid value (1): duplicate - must be unique
Print Filtered Test Results 2024-10-17T21:32:03.9990058Z - 1.Nodes.1.Name: invalid value (fake): duplicate - must be unique
Print Filtered Test Results 2024-10-17T21:32:03.9990604Z - 1.Nodes.1.WSURL: invalid value (wss://foo.bar/ws): duplicate - must be unique
Print Filtered Test Results 2024-10-17T21:32:03.9991176Z - 1.Nodes.1.HTTPURL: invalid value (https://foo.bar): duplicate - must be unique
Print Filtered Test Results 2024-10-17T21:32:03.9991375Z - Cosmos: 3 errors:
Print Filtered Test Results 2024-10-17T21:32:03.9991842Z - 1.ChainID: invalid value (Malaga-420): duplicate - must be unique
Print Filtered Test Results 2024-10-17T21:32:03.9992326Z - 1.Nodes.1.Name: invalid value (primary): duplicate - must be unique
Print Filtered Test Results 2024-10-17T21:32:03.9992954Z - 1.Nodes.1.TendermintURL: invalid value (http://tender.mint): duplicate - must be unique
Print Filtered Test Results 2024-10-17T21:32:03.9993150Z - Solana: 3 errors:
Print Filtered Test Results 2024-10-17T21:32:03.9993599Z - 1.ChainID: invalid value (mainnet): duplicate - must be unique
Print Filtered Test Results 2024-10-17T21:32:03.9994076Z - 1.Nodes.1.Name: invalid value (primary): duplicate - must be unique
Print Filtered Test Results 2024-10-17T21:32:03.9994628Z - 1.Nodes.1.URL: invalid value (http://solana.web): duplicate - must be unique
Print Filtered Test Results 2024-10-17T21:32:03.9994844Z - Starknet: 3 errors:
Print Filtered Test Results 2024-10-17T21:32:03.9995279Z - 1.ChainID: invalid value (foobar): duplicate - must be unique
Print Filtered Test Results 2024-10-17T21:32:03.9995882Z - 1.Nodes.1.Name: invalid value (primary): duplicate - must be unique
Print Filtered Test Results 2024-10-17T21:32:03.9996424Z - 1.Nodes.1.URL: invalid value (http://stark.node): duplicate - must be unique
Print Filtered Test Results 2024-10-17T21:32:03.9996600Z [exit status 1]Suggested fix: Ensure that all ChainID, Node names, and URLs in the configuration are unique. 4. Reflect slice index out of range: TestAuditLoggerConfigSource of Error:Print Filtered Test Results 2024-10-17T21:32:04.0016132Z ^[[0;31mpanic: reflect: slice index out of range [recovered] ^[[0m
Print Filtered Test Results 2024-10-17T21:32:04.0016327Z panic: reflect: slice index out of range
Print Filtered Test Results 2024-10-17T21:32:04.0016474Z goroutine 349 [running]:
Print Filtered Test Results 2024-10-17T21:32:04.0016695Z testing.tRunner.func1.2({0x3398100, 0x46f9750})
Print Filtered Test Results 2024-10-17T21:32:04.0017027Z /opt/hostedtoolcache/go/1.22.8/x64/src/testing/testing.go:1631 +0x24a
Print Filtered Test Results 2024-10-17T21:32:04.0017166Z testing.tRunner.func1()
Print Filtered Test Results 2024-10-17T21:32:04.0017487Z /opt/hostedtoolcache/go/1.22.8/x64/src/testing/testing.go:1634 +0x377
Print Filtered Test Results 2024-10-17T21:32:04.0017646Z panic({0x3398100?, 0x46f9750?})
Print Filtered Test Results 2024-10-17T21:32:04.0017948Z /opt/hostedtoolcache/go/1.22.8/x64/src/runtime/panic.go:770 +0x132
Print Filtered Test Results 2024-10-17T21:32:04.0018290Z reflect.Value.Index({0x33daea0?, 0xc000dd5f48?, 0xc00151cff8?}, 0x3508040?)
Print Filtered Test Results 2024-10-17T21:32:04.0018750Z /opt/hostedtoolcache/go/1.22.8/x64/src/reflect/value.go:1430 +0x167
Print Filtered Test Results 2024-10-17T21:32:04.0019604Z github.com/pelletier/go-toml/v2.(*decoder).handleArrayTableCollection(0xc001f4e500, {0x1, 0xc00151cff8}, {0x33daea0?, 0xc000dd5f48?, 0xc000074908?})
Print Filtered Test Results 2024-10-17T21:32:04.0020118Z /home/runner/go/pkg/mod/github.com/pelletier/go-toml/v2@v2.2.2/unmarshaler.go:423 +0x309
Print Filtered Test Results 2024-10-17T21:32:04.0020969Z github.com/pelletier/go-toml/v2.(*decoder).handleKeyPart(0xc001f4e500, {0x1, 0xc00151cff8}, {0x37eb5c0?, 0xc000dd5808?, 0xbf3005?}, 0xc000074a58, 0x43a2cd8)
Print Filtered Test Results 2024-10-17T21:32:04.0021468Z /home/runner/go/pkg/mod/github.com/pelletier/go-toml/v2@v2.2.2/unmarshaler.go:533 +0x78e
Print Filtered Test Results 2024-10-17T21:32:04.0022257Z github.com/pelletier/go-toml/v2.(*decoder).handleArrayTablePart(0xc00151cfc0?, {0x1, 0xc00151cff8}, {0x37eb5c0?, 0xc000dd5808?, 0xc001f4e500?})
Print Filtered Test Results 2024-10-17T21:32:04.0022750Z /home/runner/go/pkg/mod/github.com/pelletier/go-toml/v2@v2.2.2/unmarshaler.go:574 +0x66
Print Filtered Test Results 2024-10-17T21:32:04.0023478Z github.com/pelletier/go-toml/v2.(*decoder).handleArrayTable(0xc001f4e540?, {0x1, 0xc00151cff8}, {0x37eb5c0?, 0xc000dd5808?, 0x3011?})
Print Filtered Test Results 2024-10-17T21:32:04.0024079Z /home/runner/go/pkg/mod/github.com/pelletier/go-toml/v2@v2.2.2/unmarshaler.go:319 +0x65
Print Filtered Test Results 2024-10-17T21:32:04.0024814Z github.com/pelletier/go-toml/v2.(*decoder).handleRootExpression(0xc001f4e500, 0xc00151cfc0, {0x37eb5c0?, 0xc000dd5808?, 0x49bd36?})
Print Filtered Test Results 2024-10-17T21:32:04.0025307Z /home/runner/go/pkg/mod/github.com/pelletier/go-toml/v2@v2.2.2/unmarshaler.go:301 +0x156
Print Filtered Test Results 2024-10-17T21:32:04.0025906Z github.com/pelletier/go-toml/v2.(*decoder).fromParser(0xc001f4e500, {0x37eb5c0?, 0xc000dd5808?, 0xe6ec18?})
Print Filtered Test Results 2024-10-17T21:32:04.0026378Z /home/runner/go/pkg/mod/github.com/pelletier/go-toml/v2@v2.2.2/unmarshaler.go:257 +0xa5
Print Filtered Test Results 2024-10-17T21:32:04.0026922Z github.com/pelletier/go-toml/v2.(*decoder).FromParser(0xc001f4e500, {0x37467e0?, 0xc000dd5808?})
Print Filtered Test Results 2024-10-17T21:32:04.0027424Z /home/runner/go/pkg/mod/github.com/pelletier/go-toml/v2@v2.2.2/unmarshaler.go:242 +0x17d
Print Filtered Test Results 2024-10-17T21:32:04.0027922Z github.com/pelletier/go-toml/v2.(*Decoder).Decode(0xc000e6ecd0, {0x37467e0, 0xc000dd5808})
Print Filtered Test Results 2024-10-17T21:32:04.0028408Z /home/runner/go/pkg/mod/github.com/pelletier/go-toml/v2@v2.2.2/unmarshaler.go:135 +0x14f
Print Filtered Test Results 2024-10-17T21:32:04.0029122Z github.com/smartcontractkit/chainlink-common/pkg/config.DecodeTOML({0x4703aa0?, 0xc001fd3a40?}, {0x37467e0?, 0xc000dd5808?})
Print Filtered Test Results 2024-10-17T21:32:04.0029897Z /home/runner/go/pkg/mod/github.com/smartcontractkit/chainlink-common@v0.3.1-0.20241017135127-b283b1e14fa6/pkg/config/toml.go:14 +0x67
Print Filtered Test Results 2024-10-17T21:32:04.0030611Z github.com/smartcontractkit/chainlink/v2/core/services/chainlink.(*GeneralConfigOpts).parseConfig(0xc000dd5008, {0x3b24e20, 0x3045})
Print Filtered Test Results 2024-10-17T21:32:04.0031068Z /home/runner/work/chainlink/chainlink/core/services/chainlink/config_general.go:100 +0xcd
Print Filtered Test Results 2024-10-17T21:32:04.0031631Z github.com/smartcontractkit/chainlink/v2/core/services/chainlink.(*GeneralConfigOpts).parse(0xc000dd5008)
Print Filtered Test Results 2024-10-17T21:32:04.0032094Z /home/runner/work/chainlink/chainlink/core/services/chainlink/config_general.go:179 +0x9c
Print Filtered Test Results 2024-10-17T21:32:04.0032992Z github.com/smartcontractkit/chainlink/v2/core/services/chainlink.GeneralConfigOpts.New({{0xc001506250, 0x1, 0x1}, {0x0, 0x0, 0x0}, {{{0x0, 0x0, 0x0, 0x0, ...}, ...}, ...}, ...})
Print Filtered Test Results 2024-10-17T21:32:04.0033456Z /home/runner/work/chainlink/chainlink/core/services/chainlink/config_general.go:128 +0xae
Print Filtered Test Results 2024-10-17T21:32:04.0033998Z github.com/smartcontractkit/chainlink/v2/core/services/chainlink.TestAuditLoggerConfig(0xc0014e01a0)
Print Filtered Test Results 2024-10-17T21:32:04.0034519Z /home/runner/work/chainlink/chainlink/core/services/chainlink/config_audit_logger_test.go:13 +0xc5
Print Filtered Test Results 2024-10-17T21:32:04.0034708Z testing.tRunner(0xc0014e01a0, 0x43a1ed0)
Print Filtered Test Results 2024-10-17T21:32:04.0035024Z /opt/hostedtoolcache/go/1.22.8/x64/src/testing/testing.go:1689 +0xfb
Print Filtered Test Results 2024-10-17T21:32:04.0035219Z created by testing.(*T).Run in goroutine 1
Print Filtered Test Results 2024-10-17T21:32:04.0035667Z /opt/hostedtoolcache/go/1.22.8/x64/src/testing/testing.go:1742 +0x390Suggested fix: Ensure that the slice being accessed has the expected length before attempting to access its elements. 5. Nil pointer dereference: TestKeyRing_Encrypt_DecryptSource of Error:Print Filtered Test Results 2024-10-17T21:32:04.0217725Z ^[[0;31mpanic: runtime error: invalid memory address or nil pointer dereference [recovered] ^[[0m
Print Filtered Test Results 2024-10-17T21:32:04.0218189Z panic: runtime error: invalid memory address or nil pointer dereference
Print Filtered Test Results 2024-10-17T21:32:04.0218763Z ^[[0;31m[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x148ba33] ^[[0m
Print Filtered Test Results 2024-10-17T21:32:04.0218946Z gor
</cicore>
<operatoruici>
## AER Report: [Operator UI CI](https://github.com/smartcontractkit/chainlink/actions/runs/11437170378) ran successfully :white_check_mark:
[aer_workflow](https://github.com/smartcontractkit/chainlink/actions/runs/11437194463/job/31816207307) , [commit](https://github.com/smartcontractkit/chainlink/commit/c8c8a8776ebb052bf473168f9b2b13b69034d9a3)
</operatoruici> |
AER Report: CI Coreaer_workflow , commit , Detect Changes , Scheduled Run Frequency , Clean Go Tidy & Generate , Flakeguard Root Project / Get Tests To Run , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , GolangCI Lint (.) , Core Tests (go_core_ccip_deployment_tests) , GolangCI Lint (deployment) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , test-scripts , Flakeguard Deployment Project / Get Tests To Run , Flakeguard Deployment Project / Run Tests , Flakeguard Deployment Project / Report , Flakeguard Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/web/auth,github.com/smartcontractkit/cha... , Flakeguard Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/services/keystore/keys/tronkey, ubuntu-l... , Flakeguard Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/services/chainlink, ubuntu-latest) , Flakeguard Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/services/job, ubuntu-latest) , Flakeguard Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/services/keystore, ubuntu-latest) , Flakeguard Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/web/resolver, ubuntu-latest) , Flakeguard Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/web, ubuntu-latest) , Flakeguard Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/cmd, ubuntu-latest) , lint , SonarQube Scan , Flakey Test Detection , Flakeguard Root Project / Report 1. Missing method for field "tronKeys":[Run Tests (github.com/smartcontractkit/chainlink/v2/core/web)]Source of Error:Run tests with flakeguard 2024-12-20T07:36:38.6284719Z Error running tests: failed to parse test results: failed to attribute panic to test, using regex web\.(Test[^\.\(]+) on these strings:
Run tests with flakeguard 2024-12-20T07:36:38.6285748Z panic: *resolver.Resolver does not resolve "Query": missing method for field "tronKeys" [recovered]
Run tests with flakeguard 2024-12-20T07:36:38.6286449Z panic: *resolver.Resolver does not resolve "Query": missing method for field "tronKeys"
Run tests with flakeguard 2024-12-20T07:36:38.6286768Z
Run tests with flakeguard 2024-12-20T07:36:38.6286892Z goroutine 399 [running]:
Run tests with flakeguard 2024-12-20T07:36:38.6287234Z testing.tRunner.func1.2({0x638eea0, 0xc0011bc600})
Run tests with flakeguard 2024-12-20T07:36:38.6287766Z /opt/hostedtoolcache/go/1.23.4/x64/src/testing/testing.go:1632 +0x3fc
Run tests with flakeguard 2024-12-20T07:36:38.6288155Z testing.tRunner.func1()
Run tests with flakeguard 2024-12-20T07:36:38.6288556Z /opt/hostedtoolcache/go/1.23.4/x64/src/testing/testing.go:1635 +0x6b6
Run tests with flakeguard 2024-12-20T07:36:38.6289682Z panic({0x638eea0?, 0xc0011bc600?})
Run tests with flakeguard 2024-12-20T07:36:38.6290417Z /opt/hostedtoolcache/go/1.23.4/x64/src/runtime/panic.go:785 +0x132
Run tests with flakeguard 2024-12-20T07:36:38.6291244Z github.com/graph-gophers/graphql-go.MustParseSchema(...)
Run tests with flakeguard 2024-12-20T07:36:38.6292565Z /home/runner/go/pkg/mod/github.com/graph-gophers/graphql-go@v1.5.0/graphql.go:67
Run tests with flakeguard 2024-12-20T07:36:38.6293810Z github.com/smartcontractkit/chainlink/v2/core/web.graphqlHandler({0x7d7bc70, 0xc0023e84e0})
Run tests with flakeguard 2024-12-20T07:36:38.6294791Z /home/runner/work/chainlink/chainlink/core/web/router.go:118 +0x2d8
Run tests with flakeguard 2024-12-20T07:36:38.6295883Z github.com/smartcontractkit/chainlink/v2/core/web.NewRouter({0x7d7bc70, 0xc0023e84e0}, 0x0)
Run tests with flakeguard 2024-12-20T07:36:38.6296974Z /home/runner/work/chainlink/chainlink/core/web/router.go:99 +0x10ad
Run tests with flakeguard 2024-12-20T07:36:38.6298309Z github.com/smartcontractkit/chainlink/v2/core/web.Router({0x7d63a30, 0xc000c4cb60}, {0x7d7bc70, 0xc0023e84e0}, 0x0)
Run tests with flakeguard 2024-12-20T07:36:38.6299505Z /home/runner/work/chainlink/chainlink/core/web/helpers.go:78 +0x4f
Run tests with flakeguard 2024-12-20T07:36:38.6300736Z github.com/smartcontractkit/chainlink/v2/core/internal/cltest.NewApplicationWithConfig({0x7d63a30, 0xc000c4cb60}, {0x7d81bb0, 0xc001e68c60}, {0x0, 0x0, 0x0})
Run tests with flakeguard 2024-12-20T07:36:38.6301645Z /home/runner/work/chainlink/chainlink/core/internal/cltest/cltest.go:518 +0x3328
Run tests with flakeguard 2024-12-20T07:36:38.6302394Z github.com/smartcontractkit/chainlink/v2/core/web_test.Test_FeaturesController_List(0xc000c4cb60)
Run tests with flakeguard 2024-12-20T07:36:38.6303094Z /home/runner/work/chainlink/chainlink/core/web/features_controller_test.go:19 +0x6c
Run tests with flakeguard 2024-12-20T07:36:38.6303574Z testing.tRunner(0xc000c4cb60, 0x767cdc0)
Run tests with flakeguard 2024-12-20T07:36:38.6304146Z /opt/hostedtoolcache/go/1.23.4/x64/src/testing/testing.go:1690 +0x227
Run tests with flakeguard 2024-12-20T07:36:38.6304588Z created by testing.(*T).Run in goroutine 1
Run tests with flakeguard 2024-12-20T07:36:38.6305022Z /opt/hostedtoolcache/go/1.23.4/x64/src/testing/testing.go:1743 +0x826
Run tests with flakeguard 2024-12-20T07:36:38.6305278Z
Run tests with flakeguard 2024-12-20T07:36:38.6314379Z ##[error]Process completed with exit code 1.Suggested fix: Implement the 2. Missing method for field "tronKeys":[Run Tests (github.com/smartcontractkit/chainlink/v2/core/web/auth,github.com/smartcontractkit/chainlink/v2/core/web/presenters)]Source of Error:Run tests with flakeguard 2024-12-20T07:37:11.5149792Z Error running tests: failed to parse test results: failed to attribute panic to test, using regex auth\.(Test[^\.\(]+) on these strings:
Run tests with flakeguard 2024-12-20T07:37:11.5151730Z panic: *resolver.Resolver does not resolve "Query": missing method for field "tronKeys" [recovered]
Run tests with flakeguard 2024-12-20T07:37:11.5153110Z panic: *resolver.Resolver does not resolve "Query": missing method for field "tronKeys"
Run tests with flakeguard 2024-12-20T07:37:11.5155076Z
Run tests with flakeguard 2024-12-20T07:37:11.5155504Z goroutine 328 [running]:
Run tests with flakeguard 2024-12-20T07:37:11.5156166Z testing.tRunner.func1.2({0x62ee240, 0xc001d54f90})
Run tests with flakeguard 2024-12-20T07:37:11.5157251Z /opt/hostedtoolcache/go/1.23.4/x64/src/testing/testing.go:1632 +0x3fc
Run tests with flakeguard 2024-12-20T07:37:11.5157947Z testing.tRunner.func1()
Run tests with flakeguard 2024-12-20T07:37:11.5158690Z /opt/hostedtoolcache/go/1.23.4/x64/src/testing/testing.go:1635 +0x6b6
Run tests with flakeguard 2024-12-20T07:37:11.5159400Z panic({0x62ee240?, 0xc001d54f90?})
Run tests with flakeguard 2024-12-20T07:37:11.5159914Z /opt/hostedtoolcache/go/1.23.4/x64/src/runtime/panic.go:785 +0x132
Run tests with flakeguard 2024-12-20T07:37:11.5160448Z github.com/graph-gophers/graphql-go.MustParseSchema(...)
Run tests with flakeguard 2024-12-20T07:37:11.5161052Z /home/runner/go/pkg/mod/github.com/graph-gophers/graphql-go@v1.5.0/graphql.go:67
Run tests with flakeguard 2024-12-20T07:37:11.5161816Z github.com/smartcontractkit/chainlink/v2/core/web.graphqlHandler({0x7cb2560, 0xc000f6bba0})
Run tests with flakeguard 2024-12-20T07:37:11.5164103Z /home/runner/work/chainlink/chainlink/core/web/router.go:118 +0x2d8
Run tests with flakeguard 2024-12-20T07:37:11.5164875Z github.com/smartcontractkit/chainlink/v2/core/web.NewRouter({0x7cb2560, 0xc000f6bba0}, 0x0)
Run tests with flakeguard 2024-12-20T07:37:11.5165559Z /home/runner/work/chainlink/chainlink/core/web/router.go:99 +0x10ad
Run tests with flakeguard 2024-12-20T07:37:11.5166400Z github.com/smartcontractkit/chainlink/v2/core/web.Router({0x7c9a730, 0xc0010cfd40}, {0x7cb2560, 0xc000f6bba0}, 0x0)
Run tests with flakeguard 2024-12-20T07:37:11.5167141Z /home/runner/work/chainlink/chainlink/core/web/helpers.go:78 +0x4f
Run tests with flakeguard 2024-12-20T07:37:11.5168210Z github.com/smartcontractkit/chainlink/v2/core/internal/cltest.NewApplicationWithConfig({0x7c9a730, 0xc0010cfd40}, {0x7cb7d30, 0xc0017a3950}, {0x0, 0x0, 0x0})
Run tests with flakeguard 2024-12-20T07:37:11.5169115Z /home/runner/work/chainlink/chainlink/core/internal/cltest/cltest.go:518 +0x3328
Run tests with flakeguard 2024-12-20T07:37:11.5169910Z github.com/smartcontractkit/chainlink/v2/core/internal/cltest.NewApplicationEVMDisabled(0xc0010cfd40)
Run tests with flakeguard 2024-12-20T07:37:11.5170629Z /home/runner/work/chainlink/chainlink/core/internal/cltest/cltest.go:228 +0x65
Run tests with flakeguard 2024-12-20T07:37:11.5171347Z github.com/smartcontractkit/chainlink/v2/core/web/auth_test.TestRBAC_Routemap_Admin(0xc0010cfd40)
Run tests with flakeguard 2024-12-20T07:37:11.5172324Z /home/runner/work/chainlink/chainlink/core/web/auth/auth_test.go:340 +0x47
Run tests with flakeguard 2024-12-20T07:37:11.5172778Z testing.tRunner(0xc0010cfd40, 0x75c5aa8)
Run tests with flakeguard 2024-12-20T07:37:11.5173211Z /opt/hostedtoolcache/go/1.23.4/x64/src/testing/testing.go:1690 +0x227
Run tests with flakeguard 2024-12-20T07:37:11.5173636Z created by testing.(*T).Run in goroutine 1
Run tests with flakeguard 2024-12-20T07:37:11.5174069Z /opt/hostedtoolcache/go/1.23.4/x64/src/testing/testing.go:1743 +0x826
Run tests with flakeguard 2024-12-20T07:37:11.5174335Z
Run tests with flakeguard 2024-12-20T07:37:11.5184442Z ##[error]Process completed with exit code 1.Suggested fix: Implement the 3. Missing method for field "tronKeys":[Run Tests (github.com/smartcontractkit/chainlink/v2/core/cmd)]Source of Error:Run tests with flakeguard 2024-12-20T07:36:48.2371833Z Error running tests: failed to parse test results: failed to attribute panic to test, using regex cmd\.(Test[^\.\(]+) on these strings:
Run tests with flakeguard 2024-12-20T07:36:48.2372830Z panic: *resolver.Resolver does not resolve "Query": missing method for field "tronKeys" [recovered]
Run tests with flakeguard 2024-12-20T07:36:48.2373508Z panic: *resolver.Resolver does not resolve "Query": missing method for field "tronKeys"
Run tests with flakeguard 2024-12-20T07:36:48.2373828Z
Run tests with flakeguard 2024-12-20T07:36:48.2373942Z goroutine 339 [running]:
Run tests with flakeguard 2024-12-20T07:36:48.2374280Z testing.tRunner.func1.2({0x814f420, 0xc001df8d80})
Run tests with flakeguard 2024-12-20T07:36:48.2374815Z /opt/hostedtoolcache/go/1.23.4/x64/src/testing/testing.go:1632 +0x3fc
Run tests with flakeguard 2024-12-20T07:36:48.2375219Z testing.tRunner.func1()
Run tests with flakeguard 2024-12-20T07:36:48.2375850Z /opt/hostedtoolcache/go/1.23.4/x64/src/testing/testing.go:1635 +0x6b6
Run tests with flakeguard 2024-12-20T07:36:48.2376536Z panic({0x814f420?, 0xc001df8d80?})
Run tests with flakeguard 2024-12-20T07:36:48.2377263Z /opt/hostedtoolcache/go/1.23.4/x64/src/runtime/panic.go:785 +0x132
Run tests with flakeguard 2024-12-20T07:36:48.2378114Z github.com/graph-gophers/graphql-go.MustParseSchema(...)
Run tests with flakeguard 2024-12-20T07:36:48.2379508Z /home/runner/go/pkg/mod/github.com/graph-gophers/graphql-go@v1.5.0/graphql.go:67
Run tests with flakeguard 2024-12-20T07:36:48.2380775Z github.com/smartcontractkit/chainlink/v2/core/web.graphqlHandler({0x9c0cab0, 0xc001ba5d40})
Run tests with flakeguard 2024-12-20T07:36:48.2383206Z /home/runner/work/chainlink/chainlink/core/web/router.go:118 +0x2d8
Run tests with flakeguard 2024-12-20T07:36:48.2384277Z github.com/smartcontractkit/chainlink/v2/core/web.NewRouter({0x9c0cab0, 0xc001ba5d40}, 0x0)
Run tests with flakeguard 2024-12-20T07:36:48.2385316Z /home/runner/work/chainlink/chainlink/core/web/router.go:99 +0x10ad
Run tests with flakeguard 2024-12-20T07:36:48.2386473Z github.com
</cicore>
<operatoruici>
## AER Report: [Operator UI CI](https://github.com/smartcontractkit/chainlink/actions/runs/12427354529) ran successfully :white_check_mark:
[aer_workflow](https://github.com/smartcontractkit/chainlink/actions/runs/12427371996/job/34697075873) , [commit](https://github.com/smartcontractkit/chainlink/commit/3c241fdca49ecccbe2f7fac013040eca64b0e56e)
</operatoruici> |
|
Flaky Test Detector for
|
cfal
force-pushed
the
add-tron
branch
3 times, most recently
from
44f490e to
8d45d7f
Compare
Flakeguard Summary
Found Flaky Tests ❌
|
Flakeguard Summary
Found Flaky Tests ❌
|
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
cfal
force-pushed
the
add-tron
branch
2 times, most recently
from
8b5bea7 to
ab60f01
Compare
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
jmank88
reviewed
Dec 13, 2024
jmank88
reviewed
Dec 13, 2024
jmank88
reviewed
Dec 13, 2024
archseer
reviewed
Dec 13, 2024
There was a problem hiding this comment.
should we add the tronKeys to the graphql too? Example for Aptos
|
Yeah let's do that, it'll make integration in the UI/JD config possible |
|
added to graphql |
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
jmank88
reviewed
Dec 18, 2024
core/services/keystore/tron.go
Outdated
|
|
||
| // TronLoopKeystore implements the [github.com/smartcontractkit/chainlink-common/pkg/loop.Keystore] interface and | ||
| // handles signing for Tron messages. | ||
| type TronLoopKeystore struct { |
There was a problem hiding this comment.
Suggested change
| type TronLoopKeystore struct { | |
| type TronLOOPKeystore struct { |
jmank88
reviewed
Dec 18, 2024
Comment on lines
30
to
31
| // Address represents the 21 byte address of an Tron account. | ||
| type Address []byte |
There was a problem hiding this comment.
If it is fixed at 21 bytes, did you consider using an array for the underlying type?
Suggested change
| // Address represents the 21 byte address of an Tron account. | |
| type Address []byte | |
| // Address represents the 21 byte address of an Tron account. | |
| type Address [21]byte |
jmank88
reviewed
Dec 18, 2024
| } | ||
|
|
||
| // HexToAddress returns Address with byte values of s. | ||
| // If s is larger than len(h), s will be cropped from the left. |
There was a problem hiding this comment.
I don't think this is true currently
Suggested change
| // If s is larger than len(h), s will be cropped from the left. | |
| // If s is larger than len(h), s will be cropped from the left. |
There was a problem hiding this comment.
changed the implementation of this slightly, although not sure if its actually used at the moment
jmank88
reviewed
Dec 18, 2024
Comment on lines
26
to
30
| // Tron address should should have 20 bytes + 4 checksum + 1 Prefix | ||
| AddressLength = 20 | ||
| ) | ||
|
|
||
| // Address represents the 21 byte address of an Tron account. |
There was a problem hiding this comment.
So are addresses 20, 21, or 25 (20+4+1)?
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.