Misc fixes for CCIP1.6 staging #14665
Merged
+69
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
connorwstein
commented
Oct 4, 2024
•
connorwstein
commented
- Add BalanceAt for gas funding
- Add cap reg view
- Remove transaction receipt retries (ethereum.NotFound expected), let Confirm handle that specially
- Fix JD connectivity
WF: CI Core#42d6144No errors found in this run. 🎉 |
AnieeG
reviewed
Oct 4, 2024
| RMN map[string]v1_6.RMNRemoteView `json:"rmn,omitempty"` | ||
| OnRamp map[string]v1_6.OnRampView `json:"onRamp,omitempty"` | ||
| OffRamp map[string]v1_6.OffRampView `json:"offRamp,omitempty"` | ||
| CapabilityRegistry map[string]v1_6.CapRegView `json:"capabilityRegistry,omitempty"` |
There was a problem hiding this comment.
The contract is versioned 1.0 though
There was a problem hiding this comment.
yeah this is a bit of a weird case, its shared/multi-product 1.0 contract which we introduced in 1.6. I think still makes most sense to include in 1.6
There was a problem hiding this comment.
How about adding a comment? so that we don't end up changing it later
…chainlink into CCIP-3572-staging-ccip
AnieeG
previously approved these changes
Oct 4, 2024
|
AnieeG
approved these changes
Oct 4, 2024
ogtownsend
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.