Update integration-tests README #14577
Open
+761
−352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chudilka1
force-pushed
the
BCF-3396-update-integration-tests-readme
branch
2 times, most recently
from
5468f8c
to
95bffd2
Compare
EasterTheBunny
previously approved these changes
Sep 26, 2024
chudilka1
force-pushed
the
BCF-3396-update-integration-tests-readme
branch
3 times, most recently
from
e6ce4a0
to
00e01ef
Compare
chudilka1
requested review from
anirudhwarrier,
davidcauchi,
joaoluisam,
Tofel and
lukaszcl
lukaszcl
reviewed
Oct 2, 2024
|
|
||
| For security reasons, test secrets and sensitive information are not stored directly within the test config TOML files. Instead, these secrets are securely injected into tests using environment variables. For a detailed explanation on managing test secrets, refer to our [Test Secrets documentation](https://github.com/smartcontractkit/chainlink-testing-framework/blob/main/lib/config/README.md#test-secrets). |
There was a problem hiding this comment.
For security reasons, test secrets and sensitive information are not stored directly within the test config TOML files. Instead, these secrets are securely injected into tests using environment variables.
@chudilka1 why you removed this?
There was a problem hiding this comment.
I've removed it, as there are guidelines and references to the corresponding documents that clearly explain that. Moreover, tests will fail if there are no test secrets. There is no need to duplicate this information everywhere.
chudilka1
force-pushed
the
BCF-3396-update-integration-tests-readme
branch
3 times, most recently
from
bf0a26b
to
00fa7fe
Compare
chudilka1
force-pushed
the
BCF-3396-update-integration-tests-readme
branch
3 times, most recently
from
5ccdd6b
to
7eff681
Compare
AKhozya
requested changes
Oct 4, 2024
joaoluisam
reviewed
Oct 4, 2024
chudilka1
force-pushed
the
BCF-3396-update-integration-tests-readme
branch
from
7eff681
to
2e8fa80
Compare
AKhozya
approved these changes
Oct 4, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BCF-3396
Audit and update integration-tests READMEs.