Ccip-3076 deployment package #14209
Ccip-3076 deployment package #14209
Conversation
|
Merged develop to fix the CI builds. |
…ractkit/chainlink into ccip-3076-deployment-from-ccip
| } | ||
| } | ||
|
|
||
| //func NewMemoryEnvironmentExistingChains(t *testing.T, lggr logger.Logger, |
There was a problem hiding this comment.
@connorwstein do we need to keep it?
| } | ||
|
|
||
| func (j JobClient) ListNodes(ctx context.Context, in *nodev1.ListNodesRequest, opts ...grpc.CallOption) (*nodev1.ListNodesResponse, error) { | ||
| //TODO implement me |
| "github.com/smartcontractkit/chainlink/integration-tests/web/sdk/internal/generated" | ||
| ) | ||
|
|
||
| type Client interface { |
There was a problem hiding this comment.
We have similar web routes defined in core/web - is there an ability to consolidate/reuse existing implementations?
There was a problem hiding this comment.
can you link to what implementations you're referring to?
There was a problem hiding this comment.
hmm, my bad. I thought we had defined go APIs, but I was thinking of the scattered resolver unit tests we have that use graphql queries.
for instance,
| return selectors | ||
| } | ||
|
|
||
| func ConfirmIfNoError(chain Chain, tx *types.Transaction, err error) (uint64, error) { |
There was a problem hiding this comment.
@connorwstein changed the signature of this as discussed
| Client OnchainClient | ||
| // Note the Sign function can be abstract supporting a variety of key storage mechanisms (e.g. KMS etc). | ||
| DeployerKey *bind.TransactOpts | ||
| Confirm func(tx common.Hash) (uint64, error) |
There was a problem hiding this comment.
@connorwstein changed the signature of this as discussed
|
* deployment package inclusion * go mod * Add README * Add changeset * Fix changeset * change confirm function * ignore linter for now * core generate * add todo ticket * fix test --------- Co-authored-by: Lukasz <[email protected]> Co-authored-by: connorwstein <[email protected]>
This exposes the new style of deployment/configuration logic for other products to use. The general structure and usage is described in the README.
Notes