-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BCI-3989][core] - CR methods err when service unstarted #14123
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit cb25d0b Author: Cedric Cordenier <[email protected]> Date: Wed Aug 14 11:00:55 2024 +0100 Add enum for CapabilityType commit 6470106 Author: Cedric Cordenier <[email protected]> Date: Wed Aug 14 09:32:47 2024 +0100 Update common commit bbb11bd Merge: 5265503 3399dd6 Author: Cedric <[email protected]> Date: Wed Aug 14 09:33:34 2024 +0100 Merge branch 'develop' into KS-426-remove-panic-capability-type commit 5265503 Author: Cedric Cordenier <[email protected]> Date: Wed Aug 14 09:32:47 2024 +0100 Update common commit 3e1cc15 Merge: a80942f eb31cf7 Author: Vyzaldy Sanchez <[email protected]> Date: Tue Aug 13 11:25:22 2024 -0400 Merge branch 'develop' into KS-426-remove-panic-capability-type commit a80942f Author: Cedric Cordenier <[email protected]> Date: Mon Aug 12 14:14:24 2024 +0100 [chore] Remove panic from CapabilityType type
Still need to
EDIT:
|
Farber98
changed the title
add isStarted check
[BCI-3989][core] - CR methods err when service unstarted
Aug 16, 2024
ilija42
reviewed
Sep 2, 2024
Refactored the structure of
|
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task Description:
CR methods should throw an error if service is unstarted
This PR:
StartChainReader
andCloseChainReader
methods to the EVMChainReaderInterfaceTester
.GetLatestValue
,BatchGetLatestValues
, andQueryKey
Bind
, we can discuss later if it's needed there too.Start()
call to consumers of CR before using it.StartChainReader
andCloseChainReader
callsTicket:
Depends on: