Write Chain Target: Validate that signed report metadata matches request metadata #14066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeividasK
commented
Aug 8, 2024
| @@ -82,36 +115,11 @@ func TestWriteTarget(t *testing.T) { | |||
| require.NotNil(t, response) | |||
| }) | |||
|
|
|||
| t.Run("succeeds with empty report", func(t *testing.T) { | |||
There was a problem hiding this comment.
Removed because we no longer support a use case in which an empty report is passed to the target capability.
DeividasK
requested review from
archseer,
bolekk,
patrick-dowell and
RensR
as code owners
…t-metadata # Conflicts: # core/capabilities/targets/write_target.go # core/capabilities/targets/write_target_test.go
|
bolekk
approved these changes
Aug 9, 2024
| if len(data) < metadata.Length() { | ||
| return metadata, fmt.Errorf("data too short: %d bytes", len(data)) | ||
| } | ||
| return metadata, binary.Read(bytes.NewReader(data[:metadata.Length()]), binary.BigEndian, &metadata) |
There was a problem hiding this comment.
I didn't know that binary.Read() makes is so easy, TIL :)
There was a problem hiding this comment.
We should be able to use something similar in cap encoder too
| return buf.Bytes(), nil | ||
| } | ||
|
|
||
| func (rm ReportV1Metadata) Length() int { |
There was a problem hiding this comment.
nit: Feels a bit wasteful, could be a const... likely doesn't matter.
archseer
approved these changes
Aug 9, 2024
This was referenced Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/KS-400