-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gas limit estimation feature #14041
Merged
prashantkumar1982
merged 34 commits into
develop
from
BCI-3658-Implement-the-dynamic-gas-limit-estimation-feature
Aug 22, 2024
Merged
Gas limit estimation feature #14041
Changes from 11 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
baaeef6
Added gas limit estimation feature to EVM gas estimators
amit-momin 2ccdf9d
Added changeset
amit-momin b1d16de
Fixed linting
amit-momin 8c4b278
Merge branch 'develop' into BCI-3658-Implement-the-dynamic-gas-limit-…
amit-momin 392b93b
Added new failure tests
amit-momin 8797154
Fixed test
amit-momin 47ab728
Merge branch 'develop' into BCI-3658-Implement-the-dynamic-gas-limit-…
amit-momin 7ded8c4
Fixed mock configs in ccip capabilities
amit-momin 67a665e
Fixed configs
amit-momin a43d391
Fixed test
amit-momin e09a7ca
Refactored GetFee method
amit-momin 4305ee3
Added EstimatedGasBuffer and addressed feedback
amit-momin b6537da
Merge branch 'develop' into BCI-3658-Implement-the-dynamic-gas-limit-…
amit-momin 970c0de
Fixed linting
amit-momin 4e3afea
Merge branch 'develop' into BCI-3658-Implement-the-dynamic-gas-limit-…
amit-momin dba4cff
Fixed config doc and tests
amit-momin 2660fac
Addressed feedback
amit-momin fdf4100
Merge branch 'develop' into BCI-3658-Implement-the-dynamic-gas-limit-…
amit-momin 2a1d8b6
Fixed typo
amit-momin 9ffd1dd
Merge branch 'develop' into BCI-3658-Implement-the-dynamic-gas-limit-…
amit-momin 65950b1
Repurposed LimitMultiplier to be used as a buffer for estimated gas
amit-momin d71bfd3
Merge branch 'develop' into BCI-3658-Implement-the-dynamic-gas-limit-…
amit-momin d51878b
Updated mocks
amit-momin c583750
Removed LimitMultiplier if gas estimation fails and updated config docs
amit-momin 40ad239
Merge branch 'develop' into BCI-3658-Implement-the-dynamic-gas-limit-…
amit-momin 61039fd
Fixed Broadcaster test
amit-momin 915e009
Enabled uncapped gas limit estimation if provided fee limit is 0
amit-momin 7b8a668
Merge branch 'develop' into BCI-3658-Implement-the-dynamic-gas-limit-…
amit-momin 327d434
Updated estimate gas buffer to be a fixed value instead of using Limi…
amit-momin 9e896c0
Merge branch 'develop' into BCI-3658-Implement-the-dynamic-gas-limit-…
amit-momin 4dc5cb5
Updated log message
amit-momin 03db68e
Merge branch 'develop' into BCI-3658-Implement-the-dynamic-gas-limit-…
amit-momin fe6bb79
Updated logs
amit-momin be17d56
Merge branch 'develop' into BCI-3658-Implement-the-dynamic-gas-limit-…
prashantkumar1982 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"chainlink": minor | ||
--- | ||
|
||
Added gas limit estimation feature to EVM gas estimators #added |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious what's the F for ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think we do this because the linter doesn't like it when the field has the same name as the method to access it. Not sure why "F" but just following the pattern here