Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto-10161: replicate v2_3 to v2_3_zksync #14035

Merged
merged 10 commits into from
Aug 7, 2024
Merged

auto-10161: replicate v2_3 to v2_3_zksync #14035

merged 10 commits into from
Aug 7, 2024

Conversation

FelixFan1992
Copy link
Contributor

Requires Dependencies

Resolves Dependencies

@FelixFan1992 FelixFan1992 marked this pull request as ready for review August 5, 2024 18:29
@FelixFan1992 FelixFan1992 requested a review from a team as a code owner August 5, 2024 18:29
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 5, 2024 •
edited
Loading

LCOV of commit 2f43aad during Solidity Foundry #41129

Summary coverage rate:
  lines......: 98.7% (1838 of 1862 lines)
  functions..: 96.6% (344 of 356 functions)
  branches...: 90.7% (782 of 862 branches)

Files changed coverage rate: n/a

@FelixFan1992 FelixFan1992 requested a review from infiloop2 August 6, 2024 19:43
@FelixFan1992 FelixFan1992 requested a review from RensR as a code owner August 7, 2024 14:12
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)
11.11% Technical Debt Ratio on New Code (required ≤ 4%)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@FelixFan1992 FelixFan1992 enabled auto-merge August 7, 2024 14:46
RyanRHall
RyanRHall reviewed Aug 7, 2024
View reviewed changes
contracts/src/v0.8/automation/ZKSyncAutomationForwarder.sol
@@ -0,0 +1,92 @@
// SPDX-License-Identifier: BUSL-1.1
pragma solidity ^0.8.16;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unlocked pragma?

@FelixFan1992 FelixFan1992 added this pull request to the merge queue Aug 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 7, 2024
@FelixFan1992 FelixFan1992 added this pull request to the merge queue Aug 7, 2024
Merged via the queue into develop with commit 215277f Aug 7, 2024
118 of 119 checks passed
@FelixFan1992 FelixFan1992 deleted the auto-10161-replication branch August 7, 2024 15:45
momentmaker added a commit that referenced this pull request Aug 7, 2024
@momentmaker
Merge branch 'develop' into re-2756/goreleaser-build-image
2073502 
* develop:
  [CCIP Merge] Capabilities [CCIP-2943] (#14068)
  add OZ 5.0.2 contracts (#14065)
  enable gomods (#14042)
  auto-10161: replicate v2_3 to v2_3_zksync (#14035)
  chore: update dependabot config gomod (#14063)
  Update log trigger default values (#14051)
  bump solana commit (#14062)
  Update e2e tests definition for CI and automation workflow (#13908)
  use services.Config.NewService/Engine (#13851)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infiloop2 infiloop2 infiloop2 approved these changes

@RyanRHall RyanRHall RyanRHall approved these changes

@RensR RensR Awaiting requested review from RensR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FelixFan1992 @RyanRHall @infiloop2