-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TT-1434] Solidity Review Artifacts pipeline #14015
[TT-1434] Solidity Review Artifacts pipeline #14015
Conversation
fbeaaef
to
88c3d73
Compare
…verage exclusions
- name: Check for changes outside of artifact scope | ||
if: ${{ steps.changes.outputs.sol == 'true' }} | ||
shell: bash | ||
run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might consider moving the bash script into its own file for these longer scripts and then calling that script here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a change for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put it in a dedicated action instead of bash script:
- name: Check for changes outside of artifact scope
uses: ./.github/actions/validate-artifact-scope
if: ${{ steps.changes.outputs.sol == 'true' }}
with:
sol_files: ${{ steps.changes.outputs.sol_files }}
product: ${{ inputs.product }}
… an action, remove whitespaces
Quality Gate passedIssues Measures |
No description provided.