Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-1434] Solidity Review Artifacts pipeline #14015

Merged
merged 23 commits into from
Aug 9, 2024

Conversation

Tofel
Copy link
Contributor

@Tofel Tofel commented Aug 2, 2024

No description provided.

@Tofel Tofel changed the base branch from develop to tt_1326_update_Sol_Foundry August 5, 2024 11:46
@Tofel Tofel force-pushed the tt_1325_solidity_pipelines_genhtml branch from fbeaaef to 88c3d73 Compare August 5, 2024 11:48
@Tofel Tofel marked this pull request as ready for review August 5, 2024 12:02
@Tofel Tofel requested review from a team and RensR as code owners August 5, 2024 12:02
@Tofel Tofel requested review from a team as code owners August 6, 2024 16:10
.github/workflows/solidity-foundry-artifacts.yml Outdated Show resolved Hide resolved
.github/workflows/solidity-foundry-artifacts.yml Outdated Show resolved Hide resolved
.github/workflows/solidity-foundry-artifacts.yml Outdated Show resolved Hide resolved
.github/workflows/solidity-foundry-artifacts.yml Outdated Show resolved Hide resolved
- name: Check for changes outside of artifact scope
if: ${{ steps.changes.outputs.sol == 'true' }}
shell: bash
run: |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might consider moving the bash script into its own file for these longer scripts and then calling that script here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a change for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put it in a dedicated action instead of bash script:

      - name: Check for changes outside of artifact scope
        uses: ./.github/actions/validate-artifact-scope
        if: ${{ steps.changes.outputs.sol == 'true' }}
        with:
          sol_files: ${{ steps.changes.outputs.sol_files }}
          product: ${{ inputs.product }}

.github/workflows/solidity-foundry-artifacts.yml Outdated Show resolved Hide resolved
.github/workflows/solidity-foundry-artifacts.yml Outdated Show resolved Hide resolved
contracts/scripts/ci/generate_uml.sh Outdated Show resolved Hide resolved
contracts/scripts/ci/generate_uml.sh Outdated Show resolved Hide resolved
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@Tofel Tofel merged commit c286f72 into tt_1326_update_Sol_Foundry Aug 9, 2024
122 checks passed
@Tofel Tofel deleted the tt_1325_solidity_pipelines_genhtml branch August 9, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants