Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/merc 5829 tests set config with activation time #13925

Merged
merged 4 commits into from
Jul 25, 2024
Merged

Feature/merc 5829 tests set config with activation time #13925

merged 4 commits into from
Jul 25, 2024

Conversation

dav009
Copy link
Contributor

@dav009 dav009 commented Jul 25, 2024 •
edited
Loading

https://smartcontract-it.atlassian.net/browse/MERC-5889

What ?

  • new tests

    • unit tests for setConfigWithActivationTime
    • unit tests for removeLatestConfig

  • making ci lint pass

    • removing unused imports

@dav009 dav009 requested a review from a team July 25, 2024 04:00
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to contracts. Please run pnpm changeset in the contracts directory to add a changeset.

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@dav009 dav009 requested a review from Fletch153 July 25, 2024 12:39
@dav009 dav009 merged commit 78b34ca into feature/MERC-5829/SBRV Jul 25, 2024
120 of 125 checks passed
@dav009 dav009 deleted the feature/MERC-5829-tests-setConfigWithActivationTime branch July 25, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fletch153 Fletch153 Fletch153 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dav009 @Fletch153